discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: jlicht@fsfe.org
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH v2 5/5] Add basic integration for debbugs.
Date: Sat, 10 Jun 2023 00:59:46 -0400	[thread overview]
Message-ID: <87pm63nc8t.fsf@kyleam.com> (raw)
In-Reply-To: <20230609124829.29629-6-jlicht@fsfe.org>

jlicht@fsfe.org writes:

> From: Jelle Licht <jlicht@fsfe.org>
>
> ---
>  piem-debbugs.el | 66 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 piem-debbugs.el

Please also update the Makefile and piem.texi (Enabling integration
libraries).

>
> diff --git a/piem-debbugs.el b/piem-debbugs.el
> new file mode 100644
> index 0000000..8757ddd
> --- /dev/null
> +++ b/piem-debbugs.el
> @@ -0,0 +1,66 @@
> +;;; piem-debbugs.el --- debbugs.el integration for piem  -*- lexical-binding: t; -*-
> +
> +;; Copyright all piem contributors <piem@inbox.kyleam.com>
> +
> +;; Author: Kyle Meyer <kyle@kyleam.com>

I think your info for author instead of mine is more appropriate, since
you're adding this file.

> +;; Keywords: vc, tools
> +;; Package-Requires: ((emacs "26.3"))

debbugs.el isn't bundled with Emacs, so Package-Requires should list
debbugs too.

> +(defgroup piem-debbugs nil
> +  "debbugs integration for piem."
> +  :group 'piem)
> +
> +(defun piem-debbugs-get-inbox ()
> +  "Return inbox name from a debbugs buffer."
> +  (when (derived-mode-p 'debbugs-gnu-mode)
> +    (when-let ((gnu-package (alist-get 'package debbugs-gnu-local-query)))
> +      (piem-inbox-by-gnu-package-match gnu-package))))
> +
> +(defun piem-debbugs-get-mid ()
> +  "Return the message ID of a debbugs buffer."
> +  (when (derived-mode-p 'debbugs-gnu-mode)
> +    (let ((msgid (alist-get 'msgid (debbugs-gnu-current-status))))
> +      (when (stringp msgid)
> +        (string-trim msgid "<" ">")))))

Nice.  I haven't tested this out yet, but that looks as clean as I was
hoping it would.


  reply	other threads:[~2023-06-10  4:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 16:59 [PATCH 1/2] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-08 16:59 ` [PATCH 2/2] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-09 12:48 ` [PATCH v2 0/5] New piem-debbugs integration jlicht
2023-06-09 12:48   ` [PATCH v2 1/5] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-10  4:52     ` Kyle Meyer
2023-06-10 10:02       ` Jelle Licht
2023-06-09 12:48   ` [PATCH v2 2/5] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-10  4:55     ` Kyle Meyer
2023-06-10 10:07       ` Jelle Licht
2023-06-09 12:48   ` [PATCH v2 3/5] piem: Add piem-inbox-by-gnu-package-match jlicht
2023-06-10  4:57     ` Kyle Meyer
2023-06-10 10:08       ` Jelle Licht
2023-06-09 12:48   ` [PATCH v2 4/5] gnus: Add support for matching inbox by X-GNU-PR-PACKAGE header jlicht
2023-06-10  4:58     ` Kyle Meyer
2023-06-10 10:08       ` Jelle Licht
2023-06-09 12:48   ` [PATCH v2 5/5] Add basic integration for debbugs jlicht
2023-06-10  4:59     ` Kyle Meyer [this message]
2023-06-10 10:11       ` Jelle Licht
2023-06-10  5:00   ` [PATCH v2 0/5] New piem-debbugs integration Kyle Meyer
2023-06-10  9:58 ` [PATCH v3 " jlicht
2023-06-10  9:58   ` [PATCH v3 1/5] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-10  9:58   ` [PATCH v3 2/5] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-10  9:58   ` [PATCH v3 3/5] piem: Add piem-inbox-by-gnu-package-match jlicht
2023-06-10 23:17     ` Kyle Meyer
2023-06-10  9:58   ` [PATCH v3 4/5] piem-inbox-by-header-match: Fallback to matching via :gnu-package jlicht
2023-06-10  9:58   ` [PATCH v3 5/5] Add basic integration for debbugs jlicht
2023-06-10 23:16   ` [PATCH v3 0/5] New piem-debbugs integration Kyle Meyer
2023-06-10 23:46     ` Jelle Licht
2023-06-11  0:55       ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm63nc8t.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=jlicht@fsfe.org \
    --cc=piem@inbox.kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).