Re: [PATCH v2 3/5] piem: Add piem-inbox-by-gnu-package-match.

[Jelle Licht <jlicht@fsfe.org>]

Kyle Meyer <kyle@kyleam.com> writes:

> jlicht@fsfe.org writes:
>
>> diff --git a/piem.el b/piem.el
>> index 914dd23..3fffb0e 100644
>> --- a/piem.el
>> +++ b/piem.el
>> @@ -490,6 +490,21 @@ non-nil, make the match specific for that message."
>>                    (mail-decode-encoded-word-string val)))
>>                headers))))
>>  
>> +(defun piem-inbox-by-gnu-package-match (gnu-package)
>> +  "Return inbox based on matching :gnu-package properties.
>> +GNU-PACKAGE should be a string. This function is intended to be
>
> Convention: two spaces after period

Done in V3. Any setting or .dir-locals I can use to not consistently
keep forgetting to do this?

>> +used by libraries implementing a function for
>> +`piem-get-inbox-function'."
>> +  (when gnu-package
>> +    (catch 'hit
>> +      (dolist (inbox (piem-merged-inboxes))
>> +        (let* ((info (cdr inbox))
>> +               (p-package (plist-get info :gnu-package)))
>> +          (when (and gnu-package
>> +                     p-package
>> +                     (string-match-p p-package gnu-package))
>> +            (throw 'hit (car inbox))))))))
>> +
>
> I think it's nice to have this as a separate function, and I'm guessing
> its use in the upcoming piem-debbugs.el is one of the reasons you
> decided to do that.
>
> But perhaps piem-inbox-by-gnu-package-match should still be called in
> piem-inbox-by-header-match, following the dolist there.  The main
> advantage of that is that debbugs.el also has Rmail support, so it'd let
> piem-rmail-get-inbox take advantage of this header too.  Plus, if
> piem-notmuch users want to match against X-GNU-PR-PACKAGE for whatever
> reason, even though they should have a List-ID too, it seems like we
> might as well consistently support it.

Done in V3.