From: Jelle Licht <jlicht@fsfe.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH v2 2/5] gnus: Skip adding mboxrd from-line when not needed.
Date: Sat, 10 Jun 2023 12:07:48 +0200 [thread overview]
Message-ID: <87jzwbmxzf.fsf@fsfe.org> (raw)
In-Reply-To: <87ttvfncfm.fsf@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
> jlicht@fsfe.org writes:
>
>> From: Jelle Licht <jlicht@fsfe.org>
>
> Could you add a bit about why this is needed? Basically that, at least
> over NNTP, gnus-summary-display-article shows a plain message, but when
> debbugs.el visits an issues message with Gnus, it's already in mbox
> format.
I copied over this explanation into the commit message for V3.
>
> It'd also be nice to add a link to the relevant inbox.kyleam.com thread.
Done in V3.
> (Convention nit-pick for this and subsequent patches: please drop the
> period from the subject, ignoring all Guix muscle memory :>)
Big ask, but done in V3 ;-).
>> +(defun piem-gnus--from-line (buffer)
>> + "Returns a cons of the first line of BUFFER, if it is an
>> +mbboxrd from-line (or nil if none), and the remaining lines of
>
> typo: s/mbboxrd/mboxrd/
Done in V3.
>> +BUFFER."
>
> To follow Elisp docstring conventions, could you rewrite this so that
> the first line is self-contained sentence?
My best attempt at this, done in V3.
> It's marked as internal, so not too important, but I wonder if something
> like "piem-gnus--split-message" might give a better hint at what it
> does.
I like the current name, but not enough get out my soapbox.
Concretely, feel free to change it if you feel strongly when applying
the patches; otherwise, leaving it as-is in V3 :-).
>> + (with-current-buffer buffer
>> + (let ((start (point-min))
>> + (end (point-max)))
>> + (goto-char start)
>> + (let* ((eol (line-end-position))
>> + (line (buffer-substring-no-properties start eol)))
>> + (if (string-match-p "^From " line)
>> + (cons line (buffer-substring-no-properties (+ eol 1) end))
>> + (cons nil (buffer-substring-no-properties start end)))))))
>
> Looks fine to me. And I don't think we need to worry about
> save-excursion here, given that we're triggering the display of these
> buffers and, in general, this command is making lots of user-visible
> changes to the layout anyway (and we didn't know a way to avoid that:
> <87turabsb0.fsf@yoctocell.xyz>).
I looked into save-excursion here as well, but as you mention things are
already making several visible changes. A 'gnus-save-excursion' macro
would be nifty, but seems out-of-scope for piem imho.
next prev parent reply other threads:[~2023-06-10 10:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:59 [PATCH 1/2] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-08 16:59 ` [PATCH 2/2] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-09 12:48 ` [PATCH v2 0/5] New piem-debbugs integration jlicht
2023-06-09 12:48 ` [PATCH v2 1/5] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-10 4:52 ` Kyle Meyer
2023-06-10 10:02 ` Jelle Licht
2023-06-09 12:48 ` [PATCH v2 2/5] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-10 4:55 ` Kyle Meyer
2023-06-10 10:07 ` Jelle Licht [this message]
2023-06-09 12:48 ` [PATCH v2 3/5] piem: Add piem-inbox-by-gnu-package-match jlicht
2023-06-10 4:57 ` Kyle Meyer
2023-06-10 10:08 ` Jelle Licht
2023-06-09 12:48 ` [PATCH v2 4/5] gnus: Add support for matching inbox by X-GNU-PR-PACKAGE header jlicht
2023-06-10 4:58 ` Kyle Meyer
2023-06-10 10:08 ` Jelle Licht
2023-06-09 12:48 ` [PATCH v2 5/5] Add basic integration for debbugs jlicht
2023-06-10 4:59 ` Kyle Meyer
2023-06-10 10:11 ` Jelle Licht
2023-06-10 5:00 ` [PATCH v2 0/5] New piem-debbugs integration Kyle Meyer
2023-06-10 9:58 ` [PATCH v3 " jlicht
2023-06-10 9:58 ` [PATCH v3 1/5] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-10 9:58 ` [PATCH v3 2/5] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-10 9:58 ` [PATCH v3 3/5] piem: Add piem-inbox-by-gnu-package-match jlicht
2023-06-10 23:17 ` Kyle Meyer
2023-06-10 9:58 ` [PATCH v3 4/5] piem-inbox-by-header-match: Fallback to matching via :gnu-package jlicht
2023-06-10 9:58 ` [PATCH v3 5/5] Add basic integration for debbugs jlicht
2023-06-10 23:16 ` [PATCH v3 0/5] New piem-debbugs integration Kyle Meyer
2023-06-10 23:46 ` Jelle Licht
2023-06-11 0:55 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzwbmxzf.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=kyle@kyleam.com \
--cc=piem@inbox.kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).