From: Jelle Licht <jlicht@fsfe.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH v2 1/5] piem: Add :gnu-package keyword to piem-inboxes
Date: Sat, 10 Jun 2023 12:02:52 +0200 [thread overview]
Message-ID: <87mt17my7n.fsf@fsfe.org> (raw)
In-Reply-To: <87v8fvnclg.fsf@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
> jlicht@fsfe.org writes:
>
>> With the `:gnu-package` keyword, users can configure a regex to match
>> against the X-GNU-PR-PACKAGE email header for the GNU Bug Tracker.
>
> Is a regex needed, or would plain string comparison (on downcased
> string) be sufficient?
It is not needed, so I made it a plain-old-string that matches via
`regexp-quote' in V3. We can revisit this decision at any point if someone has
a need for more extensive matching.
> If it is needed, I think the documentation should be adjusted to mention
> it's a regex. That's a bit different than the other headers, where the
> user input value itself isn't treated as a regex, even if internally the
> match is done with a regex, mostly to handle surrounding text that comes
> along with the header. (As a complete side remark: looking at the
> :address handling, it should probably be more careful to not match just
> a substring of an address.)
>
>> ---
>> diff --git a/Documentation/piem.texi b/Documentation/piem.texi
>> index 26962a4..99185d3 100644
>> --- a/Documentation/piem.texi
>> +++ b/Documentation/piem.texi
>> @@ -168,6 +168,12 @@ repository (e.g., if the inbox receives patches for multiple projects,
>> or if you use a few dedicated Git worktrees for different types of
>> patches), set @code{:coderepo} to a list of locations.
>>
>> +@cindex issue tracking
>> +@cindex Debbugs, issue tracking system
>> +When using the Debbugs instance at @uref{https://bugs.gnu.org} to
>> +retrieve messages, an inbox can mapped to each message by setting
>> +@code{:gnu-package} for an inbox.
>
> Nice, thanks for updating the texi docs.
>
> Reading this made me think about other instances (Debian, perhaps
> others), but I'll leave worrying about that until someone interested
> comes along.
AFAIK, the GNU Bug Tracker is a bespoke deployment of Debbugs, to put it
nicely. I'd be open to extending support for other instances of Debbugs,
but preferably after getting something functional merged first, if it's
all the same to you too.
>> @@ -393,7 +395,7 @@ files."
>> (rx string-start "publicinbox."
>> (group (one-or-more not-newline)) "."
>> (group
>> - (or "address" "coderepo" "listid" "maildir" "url"))
>> + (or "address" "coderepo" "listid" "maildir" "url" "gnu-package"))
>
> Please move "gnu-package" onto the next line to avoid going too far over
> ~80 characters.
Addressed in V3.
next prev parent reply other threads:[~2023-06-10 10:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:59 [PATCH 1/2] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-08 16:59 ` [PATCH 2/2] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-09 12:48 ` [PATCH v2 0/5] New piem-debbugs integration jlicht
2023-06-09 12:48 ` [PATCH v2 1/5] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-10 4:52 ` Kyle Meyer
2023-06-10 10:02 ` Jelle Licht [this message]
2023-06-09 12:48 ` [PATCH v2 2/5] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-10 4:55 ` Kyle Meyer
2023-06-10 10:07 ` Jelle Licht
2023-06-09 12:48 ` [PATCH v2 3/5] piem: Add piem-inbox-by-gnu-package-match jlicht
2023-06-10 4:57 ` Kyle Meyer
2023-06-10 10:08 ` Jelle Licht
2023-06-09 12:48 ` [PATCH v2 4/5] gnus: Add support for matching inbox by X-GNU-PR-PACKAGE header jlicht
2023-06-10 4:58 ` Kyle Meyer
2023-06-10 10:08 ` Jelle Licht
2023-06-09 12:48 ` [PATCH v2 5/5] Add basic integration for debbugs jlicht
2023-06-10 4:59 ` Kyle Meyer
2023-06-10 10:11 ` Jelle Licht
2023-06-10 5:00 ` [PATCH v2 0/5] New piem-debbugs integration Kyle Meyer
2023-06-10 9:58 ` [PATCH v3 " jlicht
2023-06-10 9:58 ` [PATCH v3 1/5] piem: Add :gnu-package keyword to piem-inboxes jlicht
2023-06-10 9:58 ` [PATCH v3 2/5] gnus: Skip adding mboxrd from-line when not needed jlicht
2023-06-10 9:58 ` [PATCH v3 3/5] piem: Add piem-inbox-by-gnu-package-match jlicht
2023-06-10 23:17 ` Kyle Meyer
2023-06-10 9:58 ` [PATCH v3 4/5] piem-inbox-by-header-match: Fallback to matching via :gnu-package jlicht
2023-06-10 9:58 ` [PATCH v3 5/5] Add basic integration for debbugs jlicht
2023-06-10 23:16 ` [PATCH v3 0/5] New piem-debbugs integration Kyle Meyer
2023-06-10 23:46 ` Jelle Licht
2023-06-11 0:55 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt17my7n.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=kyle@kyleam.com \
--cc=piem@inbox.kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).