Re: [PATCH v2 1/5] piem: Add :gnu-package keyword to piem-inboxes

[Jelle Licht <jlicht@fsfe.org>]

Kyle Meyer <kyle@kyleam.com> writes:

> jlicht@fsfe.org writes:
>
>> With the `:gnu-package` keyword, users can configure a regex to match
>> against the X-GNU-PR-PACKAGE email header for the GNU Bug Tracker.
>
> Is a regex needed, or would plain string comparison (on downcased
> string) be sufficient?

It is not needed, so I made it a plain-old-string that matches via
`regexp-quote' in V3. We can revisit this decision at any point if someone has
a need for more extensive matching.

> If it is needed, I think the documentation should be adjusted to mention
> it's a regex.  That's a bit different than the other headers, where the
> user input value itself isn't treated as a regex, even if internally the
> match is done with a regex, mostly to handle surrounding text that comes
> along with the header.  (As a complete side remark: looking at the
> :address handling, it should probably be more careful to not match just
> a substring of an address.)
>
>> ---
>> diff --git a/Documentation/piem.texi b/Documentation/piem.texi
>> index 26962a4..99185d3 100644
>> --- a/Documentation/piem.texi
>> +++ b/Documentation/piem.texi
>> @@ -168,6 +168,12 @@ repository (e.g., if the inbox receives patches for multiple projects,
>>  or if you use a few dedicated Git worktrees for different types of
>>  patches), set @code{:coderepo} to a list of locations.
>>  
>> +@cindex issue tracking
>> +@cindex Debbugs, issue tracking system
>> +When using the Debbugs instance at @uref{https://bugs.gnu.org} to
>> +retrieve messages, an inbox can mapped to each message by setting
>> +@code{:gnu-package} for an inbox.
>
> Nice, thanks for updating the texi docs.
>
> Reading this made me think about other instances (Debian, perhaps
> others), but I'll leave worrying about that until someone interested
> comes along.

AFAIK, the GNU Bug Tracker is a bespoke deployment of Debbugs, to put it
nicely. I'd be open to extending support for other instances of Debbugs,
but preferably after getting something functional merged first, if it's
all the same to you too.

>> @@ -393,7 +395,7 @@ files."
>>                    (rx string-start "publicinbox."
>>                        (group (one-or-more not-newline)) "."
>>                        (group
>> -                       (or "address" "coderepo" "listid" "maildir" "url"))
>> +                       (or "address" "coderepo" "listid" "maildir" "url" "gnu-package"))
>
> Please move "gnu-package" onto the next line to avoid going too far over
> ~80 characters.

Addressed in V3.