Re: [PATCH v2 5/5] Add basic integration for debbugs.

[Jelle Licht <jlicht@fsfe.org>]

Kyle Meyer <kyle@kyleam.com> writes:

> jlicht@fsfe.org writes:
>
>> From: Jelle Licht <jlicht@fsfe.org>
>>
>> ---
>>  piem-debbugs.el | 66 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 66 insertions(+)
>>  create mode 100644 piem-debbugs.el
>
> Please also update the Makefile and piem.texi (Enabling integration
> libraries).

Done in V3, including cleaning up some warnings when running `make'.

>>
>> diff --git a/piem-debbugs.el b/piem-debbugs.el
>> new file mode 100644
>> index 0000000..8757ddd
>> --- /dev/null
>> +++ b/piem-debbugs.el
>> @@ -0,0 +1,66 @@
>> +;;; piem-debbugs.el --- debbugs.el integration for piem  -*- lexical-binding: t; -*-
>> +
>> +;; Copyright all piem contributors <piem@inbox.kyleam.com>
>> +
>> +;; Author: Kyle Meyer <kyle@kyleam.com>
>
> I think your info for author instead of mine is more appropriate, since
> you're adding this file.

Done in V3.

>> +;; Keywords: vc, tools
>> +;; Package-Requires: ((emacs "26.3"))
>
> debbugs.el isn't bundled with Emacs, so Package-Requires should list
> debbugs too.

I looked through the history of the debbugs.el project, and everything
we make use of seems to already exist debbugs.el version 0.29. Going
back even further than that seemed silly to me, as we already depend on
Emacs 26.3.

>> +(defgroup piem-debbugs nil
>> +  "debbugs integration for piem."
>> +  :group 'piem)
>> +
>> +(defun piem-debbugs-get-inbox ()
>> +  "Return inbox name from a debbugs buffer."
>> +  (when (derived-mode-p 'debbugs-gnu-mode)
>> +    (when-let ((gnu-package (alist-get 'package debbugs-gnu-local-query)))
>> +      (piem-inbox-by-gnu-package-match gnu-package))))
>> +
>> +(defun piem-debbugs-get-mid ()
>> +  "Return the message ID of a debbugs buffer."
>> +  (when (derived-mode-p 'debbugs-gnu-mode)
>> +    (let ((msgid (alist-get 'msgid (debbugs-gnu-current-status))))
>> +      (when (stringp msgid)
>> +        (string-trim msgid "<" ">")))))
>
> Nice.  I haven't tested this out yet, but that looks as clean as I was
> hoping it would.

Indeed, thanks for the guidance.