From: Kyle Meyer <email@example.com> To: firstname.lastname@example.org Subject: Re: [PATCH] piem-inbox-coderepo-maybe-read: Include current projectile project Date: Sun, 16 Aug 2020 14:42:01 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Kyle Meyer writes: > diff --git a/piem.el b/piem.el > index 6a3c2b3..941b7d7 100644 > --- a/piem.el > +++ b/piem.el > @@ -293,10 +293,13 @@ (defun piem-inbox-url () > (defun piem-inbox-coderepo-maybe-read () > "Like `piem-inbox-coderepo', but fall back to reading the repo." > (or (piem-inbox-coderepo) > - (and (fboundp 'projectile-relevant-known-projects) > + (and (bound-and-true-p projectile-known-projects) > (completing-read > "Project: " > - (projectile-relevant-known-projects))) > + projectile-known-projects nil t nil nil This is sneaking in a 'nil => t' change for DEFAULT. I think that makes sense, but it should be done separately. And looking at this again, there are a few other aspects of piem-inbox-coderepo-maybe-read that can be improved...
next prev parent reply other threads:[~2020-08-16 18:42 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-16 16:54 Kyle Meyer 2020-08-16 18:42 ` Kyle Meyer [this message] 2020-08-16 18:51 ` [PATCH v2 1/4] piem-inbox-coderepo-maybe-read: Reject invalid empty-string inbox Kyle Meyer 2020-08-16 18:51 ` [PATCH v2 2/4] piem-inbox-coderepo-maybe-read: Require projectile project match Kyle Meyer 2020-08-16 18:51 ` [PATCH v2 3/4] piem-inbox-coderepo-maybe-read: Include current projectile project Kyle Meyer 2020-08-16 18:51 ` [PATCH v2 4/4] piem-inbox-coderepo-maybe-read: Expand paths from projectile Kyle Meyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://git.kyleam.com/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] piem-inbox-coderepo-maybe-read: Include current projectile project' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.kyleam.com/piem/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).