discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: Re: [PATCH] piem-inbox-coderepo-maybe-read: Include current projectile project
Date: Sun, 16 Aug 2020 14:42:01 -0400	[thread overview]
Message-ID: <877dty4eme.fsf@kyleam.com> (raw)
In-Reply-To: <20200816165431.18195-1-kyle@kyleam.com>

Kyle Meyer writes:

> diff --git a/piem.el b/piem.el
> index 6a3c2b3..941b7d7 100644
> --- a/piem.el
> +++ b/piem.el
> @@ -293,10 +293,13 @@ (defun piem-inbox-url ()
>  (defun piem-inbox-coderepo-maybe-read ()
>    "Like `piem-inbox-coderepo', but fall back to reading the repo."
>    (or (piem-inbox-coderepo)
> -      (and (fboundp 'projectile-relevant-known-projects)
> +      (and (bound-and-true-p projectile-known-projects)
>             (completing-read
>              "Project: "
> -            (projectile-relevant-known-projects)))
> +            projectile-known-projects nil t nil nil

This is sneaking in a 'nil => t' change for DEFAULT.  I think that makes
sense, but it should be done separately.

And looking at this again, there are a few other aspects of
piem-inbox-coderepo-maybe-read that can be improved...

  reply	other threads:[~2020-08-16 18:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 16:54 [PATCH] piem-inbox-coderepo-maybe-read: Include current projectile project Kyle Meyer
2020-08-16 18:42 ` Kyle Meyer [this message]
2020-08-16 18:51   ` [PATCH v2 1/4] piem-inbox-coderepo-maybe-read: Reject invalid empty-string inbox Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 2/4] piem-inbox-coderepo-maybe-read: Require projectile project match Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 3/4] piem-inbox-coderepo-maybe-read: Include current projectile project Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 4/4] piem-inbox-coderepo-maybe-read: Expand paths from projectile Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dty4eme.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).