discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH v2 2/4] piem-inbox-coderepo-maybe-read: Require projectile project match
Date: Sun, 16 Aug 2020 14:51:28 -0400	[thread overview]
Message-ID: <20200816185130.32703-2-kyle@kyleam.com> (raw)
In-Reply-To: <877dty4eme.fsf@kyleam.com>

While it's possible that the caller wants to specify a path for a repo
that isn't yet registered as a project, it should be quite rare, and
disabling it decreases the chances of invalid input.
---
 piem.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/piem.el b/piem.el
index 55915f6..de298a1 100644
--- a/piem.el
+++ b/piem.el
@@ -297,7 +297,8 @@ (defun piem-inbox-coderepo-maybe-read ()
              (and (fboundp 'projectile-relevant-known-projects)
                   (completing-read
                    "Project: "
-                   (projectile-relevant-known-projects)))
+                   (projectile-relevant-known-projects)
+                   nil t))
              (and piem-use-magit
                   (fboundp 'magit-read-repository)
                   (magit-read-repository))
-- 
2.28.0


  parent reply	other threads:[~2020-08-16 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 16:54 [PATCH] piem-inbox-coderepo-maybe-read: Include current projectile project Kyle Meyer
2020-08-16 18:42 ` Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 1/4] piem-inbox-coderepo-maybe-read: Reject invalid empty-string inbox Kyle Meyer
2020-08-16 18:51   ` Kyle Meyer [this message]
2020-08-16 18:51   ` [PATCH v2 3/4] piem-inbox-coderepo-maybe-read: Include current projectile project Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 4/4] piem-inbox-coderepo-maybe-read: Expand paths from projectile Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816185130.32703-2-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).