From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms12 with LMTPS id TrKKBwN+OV+VJgAAsNZ9tg (envelope-from ) for ; Sun, 16 Aug 2020 18:42:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wIm9AgN+OV8kUQAAbx9fmQ (envelope-from ) for ; Sun, 16 Aug 2020 18:42:11 +0000 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0D6B940414 for ; Sun, 16 Aug 2020 18:42:09 +0000 (UTC) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 577F3F5791 for ; Sun, 16 Aug 2020 14:42:06 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=GunFHdpk0Lxa7g91BUcNoqo8uFg=; b=PsnRFG rkMFVTSfwU6kcG0wlaGzIvp4sKcXqxquiszOWgVYDudyt0ieeEroo+RmpGZP2gFA cHAaUKIt+MRRgWyOpK8I9EsYk1b2plhBlv8L15VobOcXFMTlzLEnP7wQye4SRTWW Zl440bKfIniKIKZ8R3+e8d9jkXPNWvNLdSIOo= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 44BB9F5790 for ; Sun, 16 Aug 2020 14:42:06 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=uwUX3rpP6wGQXnMNWvzOtucR1vU8brLrZ/lBscUMDmA=; b=uTKyjU8ZWIQSGFfYS9ZNUxOescfGOiG8tbbq68QDcL4PJPLRysXdDKRDmKUxENjHr7N6OE4q9x3Z41CnLOJQiVSTqVPRrddx/GorRpbJ7Wfj0mn/7xDItcvixnJjmyERAX3BmeDUTFsZtpuAcJ+ABafzyRxcYcFJIh3x/+fsoqs= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id A7538F578F for ; Sun, 16 Aug 2020 14:42:03 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: piem@inbox.kyleam.com Subject: Re: [PATCH] piem-inbox-coderepo-maybe-read: Include current projectile project In-Reply-To: <20200816165431.18195-1-kyle@kyleam.com> References: <20200816165431.18195-1-kyle@kyleam.com> Date: Sun, 16 Aug 2020 14:42:01 -0400 Message-ID: <877dty4eme.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 2D83D3A0-DFF0-11EA-858C-843F439F7C89-24757444!pb-smtp21.pobox.com X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=PsnRFG r; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=uTKyjU8Z; dmarc=none; spf=pass (aspmx1.migadu.com: domain of kyle@kyleam.com designates 173.228.157.53 as permitted sender) smtp.mailfrom=kyle@kyleam.com X-Spam-Score: -1.00 X-TUID: A+PX0bINeXkC Kyle Meyer writes: > diff --git a/piem.el b/piem.el > index 6a3c2b3..941b7d7 100644 > --- a/piem.el > +++ b/piem.el > @@ -293,10 +293,13 @@ (defun piem-inbox-url () > (defun piem-inbox-coderepo-maybe-read () > "Like `piem-inbox-coderepo', but fall back to reading the repo." > (or (piem-inbox-coderepo) > - (and (fboundp 'projectile-relevant-known-projects) > + (and (bound-and-true-p projectile-known-projects) > (completing-read > "Project: " > - (projectile-relevant-known-projects))) > + projectile-known-projects nil t nil nil This is sneaking in a 'nil => t' change for DEFAULT. I think that makes sense, but it should be done separately. And looking at this again, there are a few other aspects of piem-inbox-coderepo-maybe-read that can be improved...