discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH v2 3/4] piem-inbox-coderepo-maybe-read: Include current projectile project
Date: Sun, 16 Aug 2020 14:51:29 -0400	[thread overview]
Message-ID: <20200816185130.32703-3-kyle@kyleam.com> (raw)
In-Reply-To: <877dty4eme.fsf@kyleam.com>

When piem-inbox-coderepo-maybe-read is called from within a project,
the current project isn't included in the collection because
projectile-relevant-known-projects excludes it when
projectile-current-project-on-switch is at its default value.  That's
undesirable in this context; if there's a current project, it's likely
the one of interest (e.g., calling piem-b4-am-ready-from-mbox from a
project's directory).

Add the current project to the collection and make it the default.
Also, don't bother going down the projectile branch if there are no
known projects.
---
 piem.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/piem.el b/piem.el
index de298a1..f4ba96b 100644
--- a/piem.el
+++ b/piem.el
@@ -294,11 +294,14 @@ (defun piem-inbox-coderepo-maybe-read ()
   "Like `piem-inbox-coderepo', but fall back to reading the repo."
   (let ((inbox
          (or (piem-inbox-coderepo)
-             (and (fboundp 'projectile-relevant-known-projects)
+             (and (bound-and-true-p projectile-known-projects)
                   (completing-read
                    "Project: "
-                   (projectile-relevant-known-projects)
-                   nil t))
+                   projectile-known-projects nil t nil nil
+                   (when-let ((current (and (fboundp 'projectile-project-root)
+                                            (projectile-project-root))))
+                     (abbreviate-file-name current))))
+
              (and piem-use-magit
                   (fboundp 'magit-read-repository)
                   (magit-read-repository))
-- 
2.28.0


  parent reply	other threads:[~2020-08-16 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 16:54 [PATCH] " Kyle Meyer
2020-08-16 18:42 ` Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 1/4] piem-inbox-coderepo-maybe-read: Reject invalid empty-string inbox Kyle Meyer
2020-08-16 18:51   ` [PATCH v2 2/4] piem-inbox-coderepo-maybe-read: Require projectile project match Kyle Meyer
2020-08-16 18:51   ` Kyle Meyer [this message]
2020-08-16 18:51   ` [PATCH v2 4/4] piem-inbox-coderepo-maybe-read: Expand paths from projectile Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816185130.32703-3-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [PATCH v2 3/4] piem-inbox-coderepo-maybe-read: Include current projectile project' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).