discussion and development of piem
 help / color / mirror / code / Atom feed
* [PATCH 0/6] lei q: Support displaying multiple threads
@ 2021-12-28  2:20 Kyle Meyer
  2021-12-28  2:20 ` [PATCH 1/6] lei q: Allow initial input for query to be customized Kyle Meyer
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem; +Cc: Xinglu Chen

In <871r96am1q.fsf@yoctocell.xyz>, Xinglu suggested adding support for
displaying multiple threads:

> I quite like the ‘notmuch-tree’ view, would it make sense to have
> something similar if piem so one could display multiple threads in one
> buffer, instead of just display a single thread (unless I haved missed
> something) like ‘piem-lei-query-thread’?

Patch 3 of this series implements that.  Patch 1 adds a conceptually
unrelated option, but that options makes patch 3 a bit cleaner, so I'm
including it here.  Patch 4-6 tweak the presentation of the output so
that it works better with the display of multiple threads.

  [1/6] lei q: Allow initial input for query to be customized
  [2/6] lei q: Extract buffer names to variables
  [3/6] lei q: Support displaying multiple threads
  [4/6] lei q: Add date placeholder for ghost messages
  [5/6] lei q: Separate different threads with newline
  [6/6] lei q: Sort threads by date of initial message

 piem-lei.el | 103 +++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 81 insertions(+), 22 deletions(-)


base-commit: 2b08667d9165da5381e6044b1ffa0bea90241110
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/6] lei q: Allow initial input for query to be customized
  2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
@ 2021-12-28  2:20 ` Kyle Meyer
  2021-12-28  2:20 ` [PATCH 2/6] lei q: Extract buffer names to variables Kyle Meyer
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem

piem-lei-query reads with initial input of "d:20.days.ago.. ", which I
find useful because this time restriction works well with what I'm
most often searching for.  (This is a value I've long used with
Notmuch.)  However, what value of "recent" is most reasonable is
likely to vary across users, and some users may not want the
restriction at all.

Add an option so that the initial input can be easily configured.
---
 piem-lei.el | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/piem-lei.el b/piem-lei.el
index ffd72f39..4485dcdf 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -37,6 +37,12 @@ (defcustom piem-lei-lei-executable "lei"
   "Which lei executable to use."
   :type 'string)
 
+(defcustom piem-lei-query-initial-input "d:20.days.ago.. "
+  "Initial input when reading `lei q' queries."
+  :package-version '(piem . "0.4.0")
+  :type '(choice (const :tag "None" nil)
+                 (string :tag "Query")))
+
 \f
 ;;;; Helpers
 
@@ -233,7 +239,9 @@ (defun piem-lei-query (query &optional args)
 QUERY is split according to `split-string-and-unquote'."
   (interactive
    (list (split-string-and-unquote
-          (read-string "Query: " "d:20.days.ago.. " 'piem-lei-query-history))
+          (read-string "Query: "
+                       piem-lei-query-initial-input
+                       'piem-lei-query-history))
          (transient-args 'piem-lei-q)))
   (with-current-buffer (get-buffer-create "*lei-query*")
     (let ((inhibit-read-only t))
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/6] lei q: Extract buffer names to variables
  2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
  2021-12-28  2:20 ` [PATCH 1/6] lei q: Allow initial input for query to be customized Kyle Meyer
@ 2021-12-28  2:20 ` Kyle Meyer
  2021-12-28  2:20 ` [PATCH 3/6] lei q: Support displaying multiple threads Kyle Meyer
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem

The next commit will split piem-lei-query-thread into two commands,
one for general queries with threaded output and one for displaying a
single thread for a given message ID.  It makes sense to have
different buffer names for these commands, and going forward it's
likely that there will be more name tweaks (e.g., support for "locked"
buffers).

Add defvars that can be bound to control the names.
---
 piem-lei.el | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/piem-lei.el b/piem-lei.el
index 4485dcdf..9779c972 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -233,6 +233,8 @@ (defun piem-lei-query--format-date (data)
        (error "Date did not match expected format: %S" date))
      'font-lock-face 'piem-lei-query-date)))
 
+(defvar piem-lei-query--buffer-name "*lei-query*")
+
 ;;;###autoload
 (defun piem-lei-query (query &optional args)
   "Call `lei q' with QUERY and ARGS.
@@ -243,7 +245,7 @@ (defun piem-lei-query (query &optional args)
                        piem-lei-query-initial-input
                        'piem-lei-query-history))
          (transient-args 'piem-lei-q)))
-  (with-current-buffer (get-buffer-create "*lei-query*")
+  (with-current-buffer (get-buffer-create piem-lei-query--buffer-name)
     (let ((inhibit-read-only t))
       (erase-buffer)
       (piem-lei-insert-output
@@ -669,6 +671,8 @@ (defun piem-lei-query--slurp (args)
         (forward-line))
       (nreverse items))))
 
+(defvar piem-lei-query-threads--buffer-name "*lei-thread*")
+
 (defun piem-lei-query-thread (mid &optional args)
   "Show thread containing message MID.
 ARGS is passed to the underlying `lei q' call."
@@ -681,7 +685,8 @@ (defun piem-lei-query-thread (mid &optional args)
                    (append args (list "--threads") query)))
          (msgs (piem-lei-query--thread records))
          depths pt-final subject-prev)
-    (with-current-buffer (get-buffer-create "*lei-thread*")
+    (with-current-buffer
+        (get-buffer-create piem-lei-query-threads--buffer-name)
       (let ((inhibit-read-only t))
         (erase-buffer)
         (while msgs
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/6] lei q: Support displaying multiple threads
  2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
  2021-12-28  2:20 ` [PATCH 1/6] lei q: Allow initial input for query to be customized Kyle Meyer
  2021-12-28  2:20 ` [PATCH 2/6] lei q: Extract buffer names to variables Kyle Meyer
@ 2021-12-28  2:20 ` Kyle Meyer
  2021-12-28 16:03   ` Xinglu Chen
  2021-12-28  2:20 ` [PATCH 4/6] lei q: Add date placeholder for ghost messages Kyle Meyer
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem; +Cc: Xinglu Chen

piem-lei-query shows unthreaded results.  From there,
piem-lei-query-thread can be used to show the entire thread for that
result.  This design is driven largely by my use of Notmuch, where I
call notmuch-search and then follow up with a custom variant of
notmuch-tree to show _one_ thread.

However, users familiar with notmuch-tree probably expect to be able
to display _multiple_ threads.  piem-lei-query--thread already returns
a list of threads, so it really just needs to be exposed at the
command level.

Update piem-lei-query-thread to make it handle a general query,
renaming it slightly to make it clearer that the command now supports
displaying multiple threads.  Then, add a wrapper piem-lei-mid-thread
that handles the old "single thread for a given MID" behavior.

Rather than adding another suffix command to the lei-q transient
(piem-lei-query-threads in addition to the existing piem-lei-query), I
considered adding --threads to the transient and then having
piem-lei-query check whether it's in the arguments.  Conceptually, I
dislike that because it conflates threaded _display_ with lei's
--threads behavior that's instead about whether to include other
messages from a match's thread in the results.  Also, it'd mean some
downstream handling of piem-lei-buffer-args (e.g., by
piem-lei-query-show) would be complicated by the need to filter out
--threads.

Note that piem-lei-query-thread no longer sets piem-lei-buffer-mid
because the buffer is no longer tied to a single message ID, which is
okay because, unlike in show buffers, the value isn't actually used.

Suggested-by: Xinglu Chen <public@yoctocell.xyz>
Link: https://inbox.kyleam.com/piem/871r96am1q.fsf@yoctocell.xyz
---
 piem-lei.el | 41 +++++++++++++++++++++++++++--------------
 1 file changed, 27 insertions(+), 14 deletions(-)

diff --git a/piem-lei.el b/piem-lei.el
index 9779c972..63a2548e 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -176,7 +176,7 @@ (defvar piem-lei-show-mode-font-lock-keywords
 (defvar piem-lei-show-mode-map
   (let ((map (make-sparse-keymap)))
     (define-key map "s" #'piem-lei-q)
-    (define-key map "t" #'piem-lei-query-thread)
+    (define-key map "t" #'piem-lei-mid-thread)
     map)
   "Keymap for `piem-lei-show-mode'.")
 
@@ -376,7 +376,7 @@ (defvar piem-lei-query-mode-map
     (define-key map "n" #'piem-lei-query-next-line)
     (define-key map "p" #'piem-lei-query-previous-line)
     (define-key map "s" #'piem-lei-q)
-    (define-key map "t" #'piem-lei-query-thread)
+    (define-key map "t" #'piem-lei-mid-thread)
     map)
   "Keymap for `piem-lei-query-mode'.")
 
@@ -521,7 +521,8 @@ (transient-define-prefix piem-lei-q ()
    (piem-lei-q:--limit)
    (piem-lei-q:--offset)]
   ["Actions"
-   ("s" "Search with lei" piem-lei-query)])
+   ("s" "Search" piem-lei-query)
+   ("t" "Search, threaded output" piem-lei-query-threads)])
 
 \f
 ;;;;; Threading
@@ -671,17 +672,20 @@ (defun piem-lei-query--slurp (args)
         (forward-line))
       (nreverse items))))
 
-(defvar piem-lei-query-threads--buffer-name "*lei-thread*")
+(defvar piem-lei-query-threads--buffer-name piem-lei-query--buffer-name)
 
-(defun piem-lei-query-thread (mid &optional args)
-  "Show thread containing message MID.
-ARGS is passed to the underlying `lei q' call."
+(defun piem-lei-query-threads (query &optional args pt-mid)
+  "Show threads containing matches for QUERY.
+ARGS is passed to the underlying `lei q' call.  If PT-MID is
+non-nil and matches the message ID of a result, move point to
+that line."
   (interactive
-   (if-let ((mid (piem-lei-get-mid)))
-       (list mid piem-lei-buffer-args)
-     (list (read-string "Message ID: " nil nil (piem-mid)) nil)))
-  (let* ((query (list (concat "mid:" mid)))
-         (records (piem-lei-query--slurp
+   (list (split-string-and-unquote
+          (read-string "Query: "
+                       piem-lei-query-initial-input
+                       'piem-lei-query-history))
+         (transient-args 'piem-lei-q)))
+  (let* ((records (piem-lei-query--slurp
                    (append args (list "--threads") query)))
          (msgs (piem-lei-query--thread records))
          depths pt-final subject-prev)
@@ -729,17 +733,26 @@ (defun piem-lei-query-thread (mid &optional args)
                                   'font-lock-face
                                   'piem-lei-query-thread-ghost))
               (setq subject-prev nil))
-            (when (equal mid-msg mid)
+            (when (equal mid-msg pt-mid)
               (setq pt-final (line-beginning-position)))
             (insert ?\n)))
         (insert "End of lei-q results"))
       (goto-char (or pt-final (point-min)))
       (piem-lei-query-mode)
       (setq piem-lei-buffer-args args)
-      (setq piem-lei-buffer-mid mid)
       (setq  piem-lei-buffer-query query)
       (pop-to-buffer-same-window (current-buffer)))))
 
+(defun piem-lei-mid-thread (mid &optional args)
+  "Show thread containing message MID.
+ARGS is passed to the underlying `lei q' call."
+  (interactive
+   (if-let ((mid (piem-lei-get-mid)))
+       (list mid piem-lei-buffer-args)
+     (list (read-string "Message ID: " nil nil (piem-mid)) nil)))
+  (let ((piem-lei-query-threads--buffer-name "*lei-thread*"))
+    (piem-lei-query-threads (list (concat "mid:" mid)) args mid)))
+
 \f
 ;;;; piem integration
 
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 4/6] lei q: Add date placeholder for ghost messages
  2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
                   ` (2 preceding siblings ...)
  2021-12-28  2:20 ` [PATCH 3/6] lei q: Support displaying multiple threads Kyle Meyer
@ 2021-12-28  2:20 ` Kyle Meyer
  2021-12-28  2:20 ` [PATCH 5/6] lei q: Separate different threads with newline Kyle Meyer
  2021-12-28  2:20 ` [PATCH 6/6] lei q: Sort threads by date of initial message Kyle Meyer
  5 siblings, 0 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem

piem-lei-query-threads inserts only the message ID of a ghost message,
using spaces for where the date and time is for other messages.  The
space placeholders will become visually confusing when the next commit
starts inserting an empty line between threads.  Switch to using a
dummy date-time instead.
---
 piem-lei.el | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/piem-lei.el b/piem-lei.el
index 63a2548e..dedaee20 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -727,11 +727,12 @@ (defun piem-lei-query-threads (query &optional args pt-mid)
                                        (line-end-position)
                                        (list 'piem-lei-query-result data))
                   (setq subject-prev subject))
-              (insert (make-string 17 ?\s) ; Date alignment.
-                      (piem-lei-query--format-thread-marker depth)
-                      (propertize (concat " <" mid-msg ">")
-                                  'font-lock-face
-                                  'piem-lei-query-thread-ghost))
+              (insert (propertize
+                       (concat "0000-00-00 00:00 "
+                               (piem-lei-query--format-thread-marker depth)
+                               " <" mid-msg ">")
+                       'font-lock-face
+                       'piem-lei-query-thread-ghost))
               (setq subject-prev nil))
             (when (equal mid-msg pt-mid)
               (setq pt-final (line-beginning-position)))
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 5/6] lei q: Separate different threads with newline
  2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
                   ` (3 preceding siblings ...)
  2021-12-28  2:20 ` [PATCH 4/6] lei q: Add date placeholder for ghost messages Kyle Meyer
@ 2021-12-28  2:20 ` Kyle Meyer
  2021-12-28  2:20 ` [PATCH 6/6] lei q: Sort threads by date of initial message Kyle Meyer
  5 siblings, 0 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem

For piem-lei-query-threads output with multiple threads, add a newline
to make it easier to spot the start of a new thread.

In terms of presentation, I think it would also be nice to distinguish
search hits in the thread from other messages.  For local messages,
pct could be used to do this, but punt on that for now.
---
 piem-lei.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/piem-lei.el b/piem-lei.el
index dedaee20..1c232da2 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -699,6 +699,11 @@ (defun piem-lei-query-threads (query &optional args pt-mid)
                  (children (piem-lei-msg-children msg))
                  (depth (1+ (or (cdr (assoc (piem-lei-msg-parent msg) depths))
                                 -1))))
+            (when (and (equal depth 0)
+                       (not (bobp)))
+              ;; Add newline between threads to make different threads
+              ;; easier to distinguish.
+              (insert ?\n))
             (when children
               (setq msgs (append children msgs)))
             (push (cons msg depth) depths)
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 6/6] lei q: Sort threads by date of initial message
  2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
                   ` (4 preceding siblings ...)
  2021-12-28  2:20 ` [PATCH 5/6] lei q: Separate different threads with newline Kyle Meyer
@ 2021-12-28  2:20 ` Kyle Meyer
  2021-12-28 17:24   ` Kyle Meyer
  5 siblings, 1 reply; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28  2:20 UTC (permalink / raw)
  To: piem

Now that there is a command for displaying multiple threads, the order
that piem-lei-query--thread returns the threads matters.  When lei-q
is given the --threads option, the threads don't have a clear order,
and --sort and --reverse don't have an effect, so
piem-lei-query--thread must handle the sorting.

Teach piem-lei-query--thread to sort by the date of the root message
in a thread, adding a option to control the direction of this sorting.

It may be better to sort by the latest date within the entire thread.
However, doing so is more expensive, so don't bother until a clear
case is made that it's the better option.
---
 piem-lei.el | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/piem-lei.el b/piem-lei.el
index 1c232da2..db922944 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -43,6 +43,13 @@ (defcustom piem-lei-query-initial-input "d:20.days.ago.. "
   :type '(choice (const :tag "None" nil)
                  (string :tag "Query")))
 
+(defcustom piem-lei-query-oldest-thread-first nil
+  "Whether to display older threads before new ones.
+The date and time of the initial message is taken as the age of
+the thread."
+  :package-version '(piem . "0.4.0")
+  :type 'boolean)
+
 \f
 ;;;; Helpers
 
@@ -567,6 +574,20 @@ (defun piem-lei-query--has-descendant (msg1 msg2)
         (setq msg2 (piem-lei-msg-parent msg2)))
       nil)))
 
+(defun piem-lei--msg-time-with-fallback (msg)
+  (or (piem-lei-msg-time msg)
+      ;; The initial message is a ghost.  Use the time from the first
+      ;; child encountered, without making any effort to ensure that
+      ;; it's the sibling with the earliest time.
+      (catch 'stop
+        (let ((children (piem-lei-msg-children msg)))
+          (while children
+            (let ((child (pop children)))
+              (if-let ((time (piem-lei-msg-time child)))
+                  (throw 'stop time)
+                (setq children
+                      (append children (piem-lei-msg-children child))))))))))
+
 (defun piem-lei-query--thread (records)
   "Thread messages in RECORDS.
 
@@ -612,7 +633,13 @@ (defun piem-lei-query--thread (records)
          (unless (piem-lei-msg-parent v)
            (push v roots)))
        thread)
-      (nreverse roots))))
+      (let* ((fn (if piem-lei-query-oldest-thread-first #'not #'identity))
+             (sort-fn
+              (lambda (a b)
+                (funcall fn
+                         (time-less-p (piem-lei--msg-time-with-fallback b)
+                                      (piem-lei--msg-time-with-fallback a))))))
+        (sort roots sort-fn)))))
 
 (defvar piem-lei-query--subject-split-re
   (rx string-start
-- 
2.34.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/6] lei q: Support displaying multiple threads
  2021-12-28  2:20 ` [PATCH 3/6] lei q: Support displaying multiple threads Kyle Meyer
@ 2021-12-28 16:03   ` Xinglu Chen
  2021-12-28 17:26     ` Kyle Meyer
  0 siblings, 1 reply; 10+ messages in thread
From: Xinglu Chen @ 2021-12-28 16:03 UTC (permalink / raw)
  To: Kyle Meyer, piem

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

Kyle schrieb am Montag der 27. Dezember 2021 um 21:20 -05:

> piem-lei-query shows unthreaded results.  From there,
> piem-lei-query-thread can be used to show the entire thread for that
> result.  This design is driven largely by my use of Notmuch, where I
> call notmuch-search and then follow up with a custom variant of
> notmuch-tree to show _one_ thread.
>
> However, users familiar with notmuch-tree probably expect to be able
> to display _multiple_ threads.  piem-lei-query--thread already returns
> a list of threads, so it really just needs to be exposed at the
> command level.
>
> Update piem-lei-query-thread to make it handle a general query,
> renaming it slightly to make it clearer that the command now supports
> displaying multiple threads.  Then, add a wrapper piem-lei-mid-thread
> that handles the old "single thread for a given MID" behavior.
>
> Rather than adding another suffix command to the lei-q transient
> (piem-lei-query-threads in addition to the existing piem-lei-query), I
> considered adding --threads to the transient and then having
> piem-lei-query check whether it's in the arguments.  Conceptually, I
> dislike that because it conflates threaded _display_ with lei's
> --threads behavior that's instead about whether to include other
> messages from a match's thread in the results.  Also, it'd mean some
> downstream handling of piem-lei-buffer-args (e.g., by
> piem-lei-query-show) would be complicated by the need to filter out
> --threads.
>
> Note that piem-lei-query-thread no longer sets piem-lei-buffer-mid
> because the buffer is no longer tied to a single message ID, which is
> okay because, unlike in show buffers, the value isn't actually used.
>
> Suggested-by: Xinglu Chen <public@yoctocell.xyz>
> Link: https://inbox.kyleam.com/piem/871r96am1q.fsf@yoctocell.xyz
> ---
>  piem-lei.el | 41 +++++++++++++++++++++++++++--------------
>  1 file changed, 27 insertions(+), 14 deletions(-)

The changes look good to me, and things work as expected.  Thanks for
the work!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 6/6] lei q: Sort threads by date of initial message
  2021-12-28  2:20 ` [PATCH 6/6] lei q: Sort threads by date of initial message Kyle Meyer
@ 2021-12-28 17:24   ` Kyle Meyer
  0 siblings, 0 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28 17:24 UTC (permalink / raw)
  To: piem

Kyle Meyer writes:

> +(defcustom piem-lei-query-oldest-thread-first nil
> +  "Whether to display older threads before new ones.

Will apply this typo fix on top:

diff --git a/piem-lei.el b/piem-lei.el
index db922944..6c537339 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -44,7 +44,7 @@ (defcustom piem-lei-query-initial-input "d:20.days.ago.. "
                  (string :tag "Query")))
 
 (defcustom piem-lei-query-oldest-thread-first nil
-  "Whether to display older threads before new ones.
+  "Whether to display older threads before newer ones.
 The date and time of the initial message is taken as the age of
 the thread."
   :package-version '(piem . "0.4.0")

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/6] lei q: Support displaying multiple threads
  2021-12-28 16:03   ` Xinglu Chen
@ 2021-12-28 17:26     ` Kyle Meyer
  0 siblings, 0 replies; 10+ messages in thread
From: Kyle Meyer @ 2021-12-28 17:26 UTC (permalink / raw)
  To: Xinglu Chen; +Cc: piem

Xinglu Chen writes:

> The changes look good to me, and things work as expected.  Thanks for
> the work!

Great, thank you for testing it out.  Pushed (d7d15a74).

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-12-28 17:26 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
2021-12-28  2:20 ` [PATCH 1/6] lei q: Allow initial input for query to be customized Kyle Meyer
2021-12-28  2:20 ` [PATCH 2/6] lei q: Extract buffer names to variables Kyle Meyer
2021-12-28  2:20 ` [PATCH 3/6] lei q: Support displaying multiple threads Kyle Meyer
2021-12-28 16:03   ` Xinglu Chen
2021-12-28 17:26     ` Kyle Meyer
2021-12-28  2:20 ` [PATCH 4/6] lei q: Add date placeholder for ghost messages Kyle Meyer
2021-12-28  2:20 ` [PATCH 5/6] lei q: Separate different threads with newline Kyle Meyer
2021-12-28  2:20 ` [PATCH 6/6] lei q: Sort threads by date of initial message Kyle Meyer
2021-12-28 17:24   ` Kyle Meyer

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).