discussion and development of piem
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Kyle Meyer <kyle@kyleam.com>, piem@inbox.kyleam.com
Subject: Re: [PATCH 3/6] lei q: Support displaying multiple threads
Date: Tue, 28 Dec 2021 17:03:52 +0100	[thread overview]
Message-ID: <87wnjosolz.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20211228022037.206597-4-kyle@kyleam.com>

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

Kyle schrieb am Montag der 27. Dezember 2021 um 21:20 -05:

> piem-lei-query shows unthreaded results.  From there,
> piem-lei-query-thread can be used to show the entire thread for that
> result.  This design is driven largely by my use of Notmuch, where I
> call notmuch-search and then follow up with a custom variant of
> notmuch-tree to show _one_ thread.
> However, users familiar with notmuch-tree probably expect to be able
> to display _multiple_ threads.  piem-lei-query--thread already returns
> a list of threads, so it really just needs to be exposed at the
> command level.
> Update piem-lei-query-thread to make it handle a general query,
> renaming it slightly to make it clearer that the command now supports
> displaying multiple threads.  Then, add a wrapper piem-lei-mid-thread
> that handles the old "single thread for a given MID" behavior.
> Rather than adding another suffix command to the lei-q transient
> (piem-lei-query-threads in addition to the existing piem-lei-query), I
> considered adding --threads to the transient and then having
> piem-lei-query check whether it's in the arguments.  Conceptually, I
> dislike that because it conflates threaded _display_ with lei's
> --threads behavior that's instead about whether to include other
> messages from a match's thread in the results.  Also, it'd mean some
> downstream handling of piem-lei-buffer-args (e.g., by
> piem-lei-query-show) would be complicated by the need to filter out
> --threads.
> Note that piem-lei-query-thread no longer sets piem-lei-buffer-mid
> because the buffer is no longer tied to a single message ID, which is
> okay because, unlike in show buffers, the value isn't actually used.
> Suggested-by: Xinglu Chen <public@yoctocell.xyz>
> Link: https://inbox.kyleam.com/piem/871r96am1q.fsf@yoctocell.xyz
> ---
>  piem-lei.el | 41 +++++++++++++++++++++++++++--------------
>  1 file changed, 27 insertions(+), 14 deletions(-)

The changes look good to me, and things work as expected.  Thanks for
the work!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-12-28 16:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-28  2:20 [PATCH 0/6] lei q: Support displaying multiple threads Kyle Meyer
2021-12-28  2:20 ` [PATCH 1/6] lei q: Allow initial input for query to be customized Kyle Meyer
2021-12-28  2:20 ` [PATCH 2/6] lei q: Extract buffer names to variables Kyle Meyer
2021-12-28  2:20 ` [PATCH 3/6] lei q: Support displaying multiple threads Kyle Meyer
2021-12-28 16:03   ` Xinglu Chen [this message]
2021-12-28 17:26     ` Kyle Meyer
2021-12-28  2:20 ` [PATCH 4/6] lei q: Add date placeholder for ghost messages Kyle Meyer
2021-12-28  2:20 ` [PATCH 5/6] lei q: Separate different threads with newline Kyle Meyer
2021-12-28  2:20 ` [PATCH 6/6] lei q: Sort threads by date of initial message Kyle Meyer
2021-12-28 17:24   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnjosolz.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).