Re: [PATCH 1/1] piem-notmuch-am-ready-mbox: Add option to edit patches before applying them

[Leo <sourcehut@relevant-information.com>]

Kyle Meyer <kyle@kyleam.com> writes:

> Are you okay with filling in a name here?  (It of course doesn't have to
> be a real one.)
>

Sure, let's go with Leo.

> Okay, so stepping back, I believe the proposed workflow is ...
>
>

Yes that is correct. Although I realize that it is pretty clunky, see below.

> I wonder if we can redesign this a bit to more closely and transparently
> connect the "edit" and "am" parts.  Something like:
>
>   * from a notmuch message, invoke piem-notmuch-edit-message [*] (or
>     whatever name)
>
>     This commands puts the message (or perhaps thread) into a dedicated
>     piem mode for editing, setting up any buffer-local variables piem
>     needs for record-keeping/linking (e.g., what piem-inbox-coderepo
>     returns in the notmuch message) and then ...
>
>   * once the user is done editing, they can hit, say, 'C-c C-c' to call
>     a wrapper command that feeds the mbox to piem-am
>
>     (Perhaps there could also be a b4 variant.)
>
> What do you think?
>

I actually thought something similar a while after I sent the patch.
Instead of editing the buffer generated by notmuch we could use the
buffer returned by `piem-am-ready-mbox'. That way we get all the
libraries for free. Perhaps a new command `piem-am-edit' could be added
that calls `piem-am-ready-mbox' with your suggested dedicated piem mode
for editing. Would it be a good idea to filter out email headers that
`git am' doesn't care about here? Otherwise it can be a bit overwhelming.



--
---Leo