From: Kyle Meyer <kyle@kyleam.com>
To: Leo <sourcehut@relevant-information.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH 1/1] piem-notmuch-am-ready-mbox: Add option to edit patches before applying them
Date: Fri, 10 Dec 2021 00:08:40 -0500 [thread overview]
Message-ID: <871r2lf3mv.fsf@kyleam.com> (raw)
In-Reply-To: <87zgpaylus.fsf@hako.i-did-not-set--mail-host-address--so-tickle-me>
Leo writes:
> Leo <sourcehut@relevant-information.com> writes:
>
>> I actually thought something similar a while after I sent the patch.
>> Instead of editing the buffer generated by notmuch we could use the
>> buffer returned by `piem-am-ready-mbox'. That way we get all the
>> libraries for free. Perhaps a new command `piem-am-edit' could be added
>> that calls `piem-am-ready-mbox' with your suggested dedicated piem mode
>> for editing. Would it be a good idea to filter out email headers that
>> `git am' doesn't care about here? Otherwise it can be a bit overwhelming.
Yeah, filtering headers (and perhaps positioning point) sounds like a
good idea. Note sure if any built-in Emacs libraries have something to
use or at least follow here.
> Here is a sketch based on the sketch you sent. The workflow being: 1)
> call `piem-edit' 2) edit the mbox buffer 3) call `piem-edit-patch-am'.
Nice, seems like we're looking in the same general direction. (I
unfortunately don't have time tonight to give a more substantial reply
to this or your other thread.)
Is this topic something you'd like to flesh out and polish? (No worries
if not.)
next prev parent reply other threads:[~2021-12-10 5:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 16:01 Adding support for editing patches before applying them sourcehut
2021-12-08 16:01 ` [PATCH 1/1] piem-notmuch-am-ready-mbox: Add option to edit " sourcehut
2021-12-09 3:43 ` Kyle Meyer
2021-12-09 5:20 ` Kyle Meyer
2021-12-09 10:10 ` Leo
2021-12-09 13:00 ` Leo
2021-12-10 5:08 ` Kyle Meyer [this message]
2021-12-10 9:31 ` Leo
2021-12-11 21:44 ` Kyle Meyer
2021-12-16 20:05 ` [PATCH] Add ability " sourcehut
2021-12-17 5:58 ` Kyle Meyer
2021-12-21 14:02 ` [PATCH v2] " sourcehut
2021-12-24 18:32 ` Kyle Meyer
2021-12-27 16:07 ` Leo
2021-12-27 21:07 ` distributing piem via *ELPA Kyle Meyer
2021-12-27 21:30 ` Kyle Meyer
2021-12-09 3:38 ` Adding support for editing patches before applying them Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r2lf3mv.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=piem@inbox.kyleam.com \
--cc=sourcehut@relevant-information.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).