Re: [PATCH v2] Add ability to edit patches before applying them

[Kyle Meyer <kyle@kyleam.com>]

sourcehut@relevant-information.com writes:

> +(defun piem-edit-patch-am ()
> +  "Apply the patch that is currently edited."
> +  (interactive)
> +  (let ((buf (current-buffer)))
> +    (piem-am  buf
> +          "mbox"
> +          (piem-extract-mbox-info (current-buffer))
> +          piem-edit-patch--coderepo))
> +  (kill-buffer buf))

This last 'buf' is outside of the let-binding:

  $ make compile
  emacs --batch -Q -L . -L tests -f batch-byte-compile piem-maildir.el
  emacs --batch -Q -L . -L tests -f batch-byte-compile piem.el
  
  In piem-edit-patch-am:
  piem.el:1012:16:Warning: reference to free variable ‘buf’
  [...]

I've moved it inside (diff below).

Tested this out a bit, and it seems to work as advertised.  Pushed
(a996e8d4).  Thanks for proposing and implementing this feature.

diff --git a/piem.el b/piem.el
index eef06492..b06719b2 100644
--- a/piem.el
+++ b/piem.el
@@ -1005,11 +1005,11 @@ (defun piem-edit-patch-am ()
   "Apply the patch that is currently edited."
   (interactive)
   (let ((buf (current-buffer)))
-    (piem-am  buf
-          "mbox"
-          (piem-extract-mbox-info (current-buffer))
-          piem-edit-patch--coderepo))
-  (kill-buffer buf))
+    (piem-am buf
+             "mbox"
+             (piem-extract-mbox-info (current-buffer))
+             piem-edit-patch--coderepo)
+    (kill-buffer buf)))
 
 (defvar piem-edit-patch-mode-map
   (let ((map (make-sparse-keymap)))