discussion and development of piem
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [RFC PATCH v2] gnus: Add piem-gnus-mid-to-thread
Date: Thu, 21 Jan 2021 09:36:03 +0100	[thread overview]
Message-ID: <87turabsb0.fsf@yoctocell.xyz> (raw)
In-Reply-To: <87im7rt3cc.fsf@kyleam.com>

On Wed, Jan 20 2021, Kyle Meyer wrote:

> I played around with this a bit, and all series seemed to get applied
> without issues.  I think interface-wise it'd be a bit nicer if we could
> do this work behind the scenes without the user seeing any changes in
> the layout/rendering of Gnus buffers, but I'm not sure that's really
> feasible.

I couldn't really find a way to do that, all the functions seem perform
side effects instead of passing data around.

> Mostly just thinking aloud: this could be rewritten without concat by
> using (dolist ... (insert ...)), and it might eventually be worth
> considering building the mbox up in a temporary buffer rather than as a
> list of strings.  But I think it's fine as is.
> Also, I've replaced the tabs with spaces.  Sorry for not having set
> indent-tabs-mode for the project.  I've now done that in 9d60b3e.
> Pushed (c9228b9).
> Thank you!

Thanks for applying!

      reply	other threads:[~2021-01-21  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 10:34 [RFC PATCH] gnus: Add piem-gnus-mid-to-thread Xinglu Chen
2021-01-19  4:17 ` Kyle Meyer
2021-01-19  8:32   ` yoctocell
2021-01-19 23:41     ` Kyle Meyer
2021-01-20  7:27       ` Xinglu Chen
2021-01-20  8:56 ` [RFC PATCH v2] " Xinglu Chen
2021-01-21  2:45   ` Kyle Meyer
2021-01-21  8:36     ` Xinglu Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87turabsb0.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).