discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: piem@inbox.kyleam.com
Subject: Re: [RFC PATCH] gnus: Add piem-gnus-mid-to-thread
Date: Mon, 18 Jan 2021 23:17:40 -0500	[thread overview]
Message-ID: <874kjdlfvf.fsf@kyleam.com> (raw)
In-Reply-To: <dde16a7a7a212e0947fdf3afad5678bac7ad2690.1610964014.git.public@yoctocell.xyz>

Xinglu Chen writes:

> Inserts a string of the whole thread in mbox format.

Great, thanks for looking into this.

> ---
> The function works as expected when running
> 'M-: (funcall (piem-gnus-mid-thread t))', but when running
> piem-b4-am-from-mid interactively, it just inserts an empty string.
> Any ideas of why this happens?  Sorry, my elisp skills are not that great.

Yes, I think you just need to move the lambda deeper so that the
messages are collected outside of the returned function.

> diff --git a/piem-gnus.el b/piem-gnus.el
> index 5f10be8..f91f91c 100644
> --- a/piem-gnus.el
> +++ b/piem-gnus.el
> @@ -58,6 +58,30 @@
>  ;; If there is an easy way to generate an mbox for a thread in Gnus, a
>  ;; function for `piem-mid-to-thread-functions' should be defined.
> +(defun piem-gnus-mid-to-thread (_mid)

Hmm, yeah, I don't think we can convince Gnus to do much useful with the
message ID here.  However, perhaps there should at least be a check that
the given message ID matches the one for the article at point before
returning a function (i.e. claiming piem-gnus-mid-to-thread can generate
a thread for the given MID).

Also, I think this would need to be guarded by

  (derived-mode-p 'gnus-summary-mode)

or perhaps

  (derived-mode-p 'gnus-article-mode 'gnus-summary-mode)

to make sure we don't start doing this collection in buffers where it
won't work.

> +  (lambda ()

This is the lambda I was referring to in the beginning of the message.
It should be moved to deeper so that it contains only (insert ...).

> +    (save-excursion
> +      ;; Cursor has to be at the root of the thread
> +      (gnus-summary-refer-parent-article most-positive-fixnum)
> +      (let ((articles (gnus-summary-articles-in-thread))
> +	    message
> +	    ;; Just show raw message
> +	    (gnus-have-all-headers t)
> +	    gnus-article-prepare-hook
> +	    gnus-article-decode-hook
> +	    gnus-display-mime-function
> +	    gnus-break-pages)

Is the above set of variables (or this approach in general) based off of
an example from the Gnus source code?

If so, I should probably read through it to orient myself.  I am mostly
clueless when it comes to writing Gnus-related elisp and pretty much
stumble around its source code looking for something that seems close to
what I want.

> +	(mapc (lambda (article)
> +		(gnus-summary-display-article article)
> +		(push (format "From mboxrd@z Thu Jan  1 00:00:00 1970\n%s\n"
> +			      (with-current-buffer gnus-article-buffer
> +				(buffer-substring-no-properties
> +				 (point-min)
> +				 (point-max))))
> +			      message))
> +		articles)

For mboxrd, I suppose there needs to be some From-munging.

> +	      (insert (apply #'concat (nreverse message)))))))

  reply	other threads:[~2021-01-19  4:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 10:34 [RFC PATCH] gnus: Add piem-gnus-mid-to-thread Xinglu Chen
2021-01-19  4:17 ` Kyle Meyer [this message]
2021-01-19  8:32   ` yoctocell
2021-01-19 23:41     ` Kyle Meyer
2021-01-20  7:27       ` Xinglu Chen
2021-01-20  8:56 ` [RFC PATCH v2] " Xinglu Chen
2021-01-21  2:45   ` Kyle Meyer
2021-01-21  8:36     ` Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kjdlfvf.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --cc=public@yoctocell.xyz \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).