From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <public@yoctocell.xyz>
Received: from mp0 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms12 with LMTPS
	id EBXlBPo8CWC3SgAAsNZ9tg
	(envelope-from <public@yoctocell.xyz>)
	for <larch@inbox.kyleam.com>; Thu, 21 Jan 2021 08:36:10 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0 with LMTPS
	id +AaBKvg8CWAwQgAA1q6Kng
	(envelope-from <public@yoctocell.xyz>)
	for <larch@inbox.kyleam.com>; Thu, 21 Jan 2021 08:36:08 +0000
Received: from mail.yoctocell.xyz (h87-96-130-155.cust.a3fiber.se [87.96.130.155])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 8C650940149
	for <piem@inbox.kyleam.com>; Thu, 21 Jan 2021 08:36:05 +0000 (UTC)
From: Xinglu Chen <public@yoctocell.xyz>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz;
	s=mail; t=1611218163;
	bh=kjdOQZ1AK7e1EhyoCLyVDy7U7c63F6i7kM03tflD/IQ=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=buDQyW/sZwO7KaKq39WxRto6JEa8yQQavtGDNbO8cRRECp0+OKUpM3MwHB9/TjbBJ
	 R2LichbRbLPu30B5eEwAh5UGtwVokTPFugQ/6D7UJjB2O9JHVszzywbues8A5Dnl/F
	 kd1Vrpu9HStmFzxurCb5CnG6dvAmU9Bsm2zXkEGg=
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [RFC PATCH v2] gnus: Add piem-gnus-mid-to-thread
In-Reply-To: <87im7rt3cc.fsf@kyleam.com>
References: <dde16a7a7a212e0947fdf3afad5678bac7ad2690.1610964014.git.public@yoctocell.xyz>
 <796fb84d852f2a5adea1502db144dae1bdc4fe0c.1611132172.git.public@yoctocell.xyz>
 <87im7rt3cc.fsf@kyleam.com>
Date: Thu, 21 Jan 2021 09:36:03 +0100
Message-ID: <87turabsb0.fsf@yoctocell.xyz>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_IN
X-Migadu-Spam-Score: -4.00
Authentication-Results: aspmx1.migadu.com;
	none
X-Migadu-Queue-Id: 8C650940149
X-Spam-Score: -4.00
X-Migadu-Scanner: scn1.migadu.com
X-TUID: z2j8teFQaKsY

On Wed, Jan 20 2021, Kyle Meyer wrote:

> I played around with this a bit, and all series seemed to get applied
> without issues.  I think interface-wise it'd be a bit nicer if we could
> do this work behind the scenes without the user seeing any changes in
> the layout/rendering of Gnus buffers, but I'm not sure that's really
> feasible.

I couldn't really find a way to do that, all the functions seem perform
side effects instead of passing data around.

> Mostly just thinking aloud: this could be rewritten without concat by
> using (dolist ... (insert ...)), and it might eventually be worth
> considering building the mbox up in a temporary buffer rather than as a
> list of strings.  But I think it's fine as is.
>
> Also, I've replaced the tabs with spaces.  Sorry for not having set
> indent-tabs-mode for the project.  I've now done that in 9d60b3e.
>
> Pushed (c9228b9).
>
> Thank you!

Thanks for applying!