discussion and development of piem
 help / color / mirror / code / Atom feed
* [PATCH] piem-edit-patch-am: Relay piem-am-ready-mbox's format
@ 2021-12-28 17:04 Kyle Meyer
  2021-12-29 12:28 ` Leo
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle Meyer @ 2021-12-28 17:04 UTC (permalink / raw)
  To: piem; +Cc: Leo

piem-edit stores the format returned by piem-am-ready-mbox in a
buffer-local variable, piem-edit-patch--format.  However,
piem-edit-patch-am doesn't use this value when it calls piem-am,
instead passing a hard-coded "mbox".

Pass piem-edit-patch--format so that git-am is called with the
appropriate format.

Cc: Leo <sourcehut@relevant-information.com>
---
 piem.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/piem.el b/piem.el
index b06719b2..b839942e 100644
--- a/piem.el
+++ b/piem.el
@@ -1006,7 +1006,7 @@ (defun piem-edit-patch-am ()
   (interactive)
   (let ((buf (current-buffer)))
     (piem-am buf
-             "mbox"
+             piem-edit-patch--format
              (piem-extract-mbox-info (current-buffer))
              piem-edit-patch--coderepo)
     (kill-buffer buf)))

base-commit: 2b08667d9165da5381e6044b1ffa0bea90241110
-- 
2.34.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] piem-edit-patch-am: Relay piem-am-ready-mbox's format
  2021-12-28 17:04 [PATCH] piem-edit-patch-am: Relay piem-am-ready-mbox's format Kyle Meyer
@ 2021-12-29 12:28 ` Leo
  0 siblings, 0 replies; 2+ messages in thread
From: Leo @ 2021-12-29 12:28 UTC (permalink / raw)
  To: Kyle Meyer, piem

I was sure that I changed it from using the hard coded value -.-

Anyways this looks good to me.  There was no specific reason for me to
use "mbox" instead of the buffer-local variable.

Kyle Meyer <kyle@kyleam.com> writes:

> piem-edit stores the format returned by piem-am-ready-mbox in a
> buffer-local variable, piem-edit-patch--format.  However,
> piem-edit-patch-am doesn't use this value when it calls piem-am,
> instead passing a hard-coded "mbox".
>
> Pass piem-edit-patch--format so that git-am is called with the
> appropriate format.
>
> Cc: Leo <sourcehut@relevant-information.com>
> ---
>  piem.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/piem.el b/piem.el
> index b06719b2..b839942e 100644
> --- a/piem.el
> +++ b/piem.el
> @@ -1006,7 +1006,7 @@ (defun piem-edit-patch-am ()
>    (interactive)
>    (let ((buf (current-buffer)))
>      (piem-am buf
> -             "mbox"
> +             piem-edit-patch--format
>               (piem-extract-mbox-info (current-buffer))
>               piem-edit-patch--coderepo)
>      (kill-buffer buf)))
>
> base-commit: 2b08667d9165da5381e6044b1ffa0bea90241110
> -- 
> 2.34.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-29 12:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-28 17:04 [PATCH] piem-edit-patch-am: Relay piem-am-ready-mbox's format Kyle Meyer
2021-12-29 12:28 ` Leo

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).