discussion and development of piem
 help / color / mirror / code / Atom feed
From: Leo <sourcehut@relevant-information.com>
To: Kyle Meyer <kyle@kyleam.com>, piem@inbox.kyleam.com
Subject: Re: [PATCH] piem-edit-patch-am: Relay piem-am-ready-mbox's format
Date: Wed, 29 Dec 2021 13:28:43 +0100	[thread overview]
Message-ID: <871r1vmw78.fsf@hako.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20211228170417.216825-1-kyle@kyleam.com>

I was sure that I changed it from using the hard coded value -.-

Anyways this looks good to me.  There was no specific reason for me to
use "mbox" instead of the buffer-local variable.

Kyle Meyer <kyle@kyleam.com> writes:

> piem-edit stores the format returned by piem-am-ready-mbox in a
> buffer-local variable, piem-edit-patch--format.  However,
> piem-edit-patch-am doesn't use this value when it calls piem-am,
> instead passing a hard-coded "mbox".
> Pass piem-edit-patch--format so that git-am is called with the
> appropriate format.
> Cc: Leo <sourcehut@relevant-information.com>
> ---
>  piem.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/piem.el b/piem.el
> index b06719b2..b839942e 100644
> --- a/piem.el
> +++ b/piem.el
> @@ -1006,7 +1006,7 @@ (defun piem-edit-patch-am ()
>    (interactive)
>    (let ((buf (current-buffer)))
>      (piem-am buf
> -             "mbox"
> +             piem-edit-patch--format
>               (piem-extract-mbox-info (current-buffer))
>               piem-edit-patch--coderepo)
>      (kill-buffer buf)))
> base-commit: 2b08667d9165da5381e6044b1ffa0bea90241110
> -- 
> 2.34.0

      reply	other threads:[~2021-12-29 12:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-28 17:04 [PATCH] piem-edit-patch-am: Relay piem-am-ready-mbox's format Kyle Meyer
2021-12-29 12:28 ` Leo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r1vmw78.fsf@hako.i-did-not-set--mail-host-address--so-tickle-me \
    --to=sourcehut@relevant-information.com \
    --cc=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).