discussion and development of piem
 help / color / mirror / Atom feed
* [PATCH] inject: Anchor 'From mboxrd@z ...' search
@ 2021-01-19  5:40 Kyle Meyer
  0 siblings, 0 replies; only message in thread
From: Kyle Meyer @ 2021-01-19  5:40 UTC (permalink / raw)
  To: piem

piem--write-mbox-to-maildir finds the bounds for each message by doing
a plain search for "From mboxrd@z", but of course nothing prevents
that from being within the text of the message.  Anchor it to the
start of the line to prevent false positives.
---

  This embarrassing gem was found when trying to inject
  <dde16a7a7a212e0947fdf3afad5678bac7ad2690.1610964014.git.public@yoctocell.xyz>.

 piem.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/piem.el b/piem.el
index 8c23e7b..867a7e5 100644
--- a/piem.el
+++ b/piem.el
@@ -489,9 +489,9 @@ (defun piem--write-mbox-to-maildir ()
   (let ((n-added 0)
         (n-skipped 0))
     (while (and (not (eobp))
-                (search-forward "From mboxrd@z" nil t))
+                (re-search-forward "^From mboxrd@z" nil t))
       (let* ((beg (line-beginning-position 2))
-             (end (or (and (search-forward "From mboxrd@z" nil t)
+             (end (or (and (re-search-forward "^From mboxrd@z" nil t)
                            (progn (goto-char (line-beginning-position 0))
                                   (point-marker)))
                       (point-max-marker)))

base-commit: 9abfc09d24e73044f2392f45fc41169ee4afd72f
-- 
2.29.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-19  5:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19  5:40 [PATCH] inject: Anchor 'From mboxrd@z ...' search Kyle Meyer

discussion and development of piem

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.kyleam.com/piem/0 piem/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 piem piem/ https://inbox.kyleam.com/piem \
		piem@inbox.kyleam.com
	public-inbox-index piem

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.piem


code repositories for the project(s) associated with this inbox:

	https://git.kyleam.com/piem/

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git