discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH] inject: Anchor 'From mboxrd@z ...' search
Date: Tue, 19 Jan 2021 00:40:42 -0500	[thread overview]
Message-ID: <20210119054042.11985-1-kyle@kyleam.com> (raw)

piem--write-mbox-to-maildir finds the bounds for each message by doing
a plain search for "From mboxrd@z", but of course nothing prevents
that from being within the text of the message.  Anchor it to the
start of the line to prevent false positives.
---

  This embarrassing gem was found when trying to inject
  <dde16a7a7a212e0947fdf3afad5678bac7ad2690.1610964014.git.public@yoctocell.xyz>.

 piem.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/piem.el b/piem.el
index 8c23e7b..867a7e5 100644
--- a/piem.el
+++ b/piem.el
@@ -489,9 +489,9 @@ (defun piem--write-mbox-to-maildir ()
   (let ((n-added 0)
         (n-skipped 0))
     (while (and (not (eobp))
-                (search-forward "From mboxrd@z" nil t))
+                (re-search-forward "^From mboxrd@z" nil t))
       (let* ((beg (line-beginning-position 2))
-             (end (or (and (search-forward "From mboxrd@z" nil t)
+             (end (or (and (re-search-forward "^From mboxrd@z" nil t)
                            (progn (goto-char (line-beginning-position 0))
                                   (point-marker)))
                       (point-max-marker)))

base-commit: 9abfc09d24e73044f2392f45fc41169ee4afd72f
-- 
2.29.2


                 reply	other threads:[~2021-01-19  5:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210119054042.11985-1-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).