From: Kyle Meyer <kyle@kyleam.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH 0/6] Support applying patches in a new worktree
Date: Sun, 15 Nov 2020 17:32:34 -0500 [thread overview]
Message-ID: <87wnymuu7x.fsf@kyleam.com> (raw)
In-Reply-To: <87v9e6l8uf.fsf@kyleam.com>
Kyle Meyer writes:
> Sure, no rush. I'll probably review this series with fresh eyes later
> today or tomorrow and merge it in, but everything will of course still
> be open for discussion after that point, and any feedback is very
> welcome.
I've taken another look and was more or less happy with it (and in
general think worktree creation should be supported in some way). The
text added to the manual feels a bit off, but I think that may be due to
a wider need to rearrange things. Dunno.
Pushed with a couple of minor tweaks.
1: 613b625 = 1: 613b625 piem-am: Rephrase CODEREPO description
2: 291878e = 2: 291878e piem-am: Store "empty string" branch check
3: a8b3342 ! 3: 060055d am: Support creating a new worktree
@@ piem.el: (defun piem-name-branch-who-what-v (info)
+This function is intended to be used as a value of
+`piem-am-read-worktree-function'. The worktree directory is
+completed from the parent directory of CODEREPO. If BRANCH is
-+non-nil, it is used as for construct the default completion."
++non-nil, it is used to construct the default completion value."
+ (let ((fname (directory-file-name coderepo)))
+ (read-directory-name
+ "Create worktree: "
4: 6250619 = 4: 251f9a2 am: Add option to configure how worktree is read
5: 92e1d7d = 5: 688c878 am: Allow flipping worktree creation with prefix argument
6: d089154 ! 6: 5db8c31 manual: Document worktree-related options
@@ piem.texi: Applying patches contained in a message
@vindex piem-use-magit
When piem loads, it detects whether Magit is loaded and sets
@@ piem.texi: Using b4 to apply patches
+ @itemx M-x piem-b4-am-from-mid
+ @findex piem-b4-am-from-mid
+ @findex piem-mid
++@vindex piem-am-create-worktree
++@vindex piem-am-read-worktree-function
+ Generate or download a thread's mbox for the current buffer's message
+ ID, process it into an am-ready mbox with b4, and then feed it to
+ @code{git am} called within an associated Git repository. If a message
ID of the current buffer is not known (i.e. @code{piem-mid} returns
nil), one is read from the caller. The caller is also queried for the
branch name and base, as described for @code{piem-am} (@pxref{Applying
next prev parent reply other threads:[~2020-11-15 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 6:15 [PATCH 0/6] Support applying patches in a new worktree Kyle Meyer
2020-11-15 6:15 ` [PATCH 1/6] piem-am: Rephrase CODEREPO description Kyle Meyer
2020-11-15 6:15 ` [PATCH 2/6] piem-am: Store "empty string" branch check Kyle Meyer
2020-11-15 6:15 ` [PATCH 3/6] am: Support creating a new worktree Kyle Meyer
2020-11-15 6:15 ` [PATCH 4/6] am: Add option to configure how worktree is read Kyle Meyer
2020-11-15 6:15 ` [PATCH 5/6] am: Allow flipping worktree creation with prefix argument Kyle Meyer
2020-11-15 6:15 ` [PATCH 6/6] manual: Document worktree-related options Kyle Meyer
2020-11-15 13:31 ` [PATCH 0/6] Support applying patches in a new worktree zimoun
2020-11-15 19:26 ` Kyle Meyer
2020-11-15 22:32 ` Kyle Meyer [this message]
2020-11-15 23:47 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnymuu7x.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=piem@inbox.kyleam.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).