From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms12 with LMTPS id hH2VM4essV8SGgAAsNZ9tg (envelope-from ) for ; Sun, 15 Nov 2020 22:32:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2GXeLoessV+CcgAA1q6Kng (envelope-from ) for ; Sun, 15 Nov 2020 22:32:39 +0000 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50A919406FA for ; Sun, 15 Nov 2020 22:32:38 +0000 (UTC) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6292F8E38D; Sun, 15 Nov 2020 17:32:36 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type; s=sasl; bh=8xn6iX4Bssix05d7EHLZc114LNY=; b=acZRInJVLcn6D876xCka rk6CRm7yQF2ROkVog8bDpkzRWMjST+v57hTAG3VEY933fRlqYMVw3esH+OF8y13Q qE5I9u8ptgq22wJ9GZbI0bE0NShjW2hpvKttjk6dD4DVaMvL+RMF8EsQBiwpAigl Lm0Q9ElXGa9uWiP+BTQzRLE= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 4EA058E38C; Sun, 15 Nov 2020 17:32:36 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version:content-type; s=mesmtp; bh=PLSkBwpsWS2aRwItFz7P72idQv/PPZ6oEhQb9g5hYo8=; b=vTUlKcTKnsSq7QmYxgduDLu0Vh7fR0hdlw311dSqYhfXL1D7jKRdxnLVjcObddlseuJzbSwPmgghSjOxeuPNTAmorMF8+cJGXmnBDunujxKnqob9JPX2NYFZ5P0ZvxKizyAh8ZCegTwXVAyKAhb5lLyHSKCq6KCCWi3lxJTOPxQ= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 5995D8E38B; Sun, 15 Nov 2020 17:32:35 -0500 (EST) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: zimoun Cc: piem@inbox.kyleam.com Subject: Re: [PATCH 0/6] Support applying patches in a new worktree In-Reply-To: <87v9e6l8uf.fsf@kyleam.com> Date: Sun, 15 Nov 2020 17:32:34 -0500 Message-ID: <87wnymuu7x.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 756F308A-2792-11EB-85D4-74DE23BA3BAF-24757444!pb-smtp2.pobox.com X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=acZRInJV; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=vTUlKcTK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of kyle@kyleam.com designates 64.147.108.71 as permitted sender) smtp.mailfrom=kyle@kyleam.com X-Spam-Score: -1.00 X-TUID: vBOAStpKlEG2 Kyle Meyer writes: > Sure, no rush. I'll probably review this series with fresh eyes later > today or tomorrow and merge it in, but everything will of course still > be open for discussion after that point, and any feedback is very > welcome. I've taken another look and was more or less happy with it (and in general think worktree creation should be supported in some way). The text added to the manual feels a bit off, but I think that may be due to a wider need to rearrange things. Dunno. Pushed with a couple of minor tweaks. 1: 613b625 = 1: 613b625 piem-am: Rephrase CODEREPO description 2: 291878e = 2: 291878e piem-am: Store "empty string" branch check 3: a8b3342 ! 3: 060055d am: Support creating a new worktree @@ piem.el: (defun piem-name-branch-who-what-v (info) +This function is intended to be used as a value of +`piem-am-read-worktree-function'. The worktree directory is +completed from the parent directory of CODEREPO. If BRANCH is -+non-nil, it is used as for construct the default completion." ++non-nil, it is used to construct the default completion value." + (let ((fname (directory-file-name coderepo))) + (read-directory-name + "Create worktree: " 4: 6250619 = 4: 251f9a2 am: Add option to configure how worktree is read 5: 92e1d7d = 5: 688c878 am: Allow flipping worktree creation with prefix argument 6: d089154 ! 6: 5db8c31 manual: Document worktree-related options @@ piem.texi: Applying patches contained in a message @vindex piem-use-magit When piem loads, it detects whether Magit is loaded and sets @@ piem.texi: Using b4 to apply patches + @itemx M-x piem-b4-am-from-mid + @findex piem-b4-am-from-mid + @findex piem-mid ++@vindex piem-am-create-worktree ++@vindex piem-am-read-worktree-function + Generate or download a thread's mbox for the current buffer's message + ID, process it into an am-ready mbox with b4, and then feed it to + @code{git am} called within an associated Git repository. If a message ID of the current buffer is not known (i.e. @code{piem-mid} returns nil), one is read from the caller. The caller is also queried for the branch name and base, as described for @code{piem-am} (@pxref{Applying