Re: [PATCH] piem-am: Order attached patches by file name prefix

[Ihor Radchenko <yantar92@gmail.com>]

Kyle Meyer <kyle@kyleam.com> writes:

> Regardless of what you call it, I don't mind piem trying to be more
> clever/helpful in these scenarios.  How about something like this?
> (Tested on <87v8s8n1bm.fsf@heagren.com> from Notmuch and Gnus.)

LGTM!
I only have some minor comments on the code.

>  (defun piem-gnus-am-ready-mbox ()
>    "Return a function that inserts an am-ready mbox.
> +
>  If the buffer has any MIME parts that look like a patch, use
> -those parts' contents (in order) as the mbox.  Otherwise, use the
> -message itself if it looks like a patch."
> +those parts' contents as the mbox, ordering the patches based on
> +the number at the start of the file name.  If none of the file
> +names start with a number, retain the original order of the
> +attachments.
> ...
>  (defun piem-notmuch-am-ready-mbox ()
>    "Return a function that inserts an am-ready mbox.
> +
>  If the buffer has any MIME parts that look like a patch, use
> -those parts' contents (in order) as the mbox.  Otherwise, use the
> -message itself if it looks like a patch."
> +those parts' contents as the mbox, ordering the patches based on
> +the number at the start of the file name.  If none of the file
> +names start with a number, retain the original order of the
> +attachments.

There is certainly some code duplication going on here (;

> +  (when (listp handle)
> +    (let ((type (mm-handle-media-type handle))
> +          (filename (mm-handle-filename handle)))
> +      (and (or (member type '("text/x-diff" "text/x-patch"))
> +               (and filename
> +                    (equal type "text/plain")
> +                    (string-suffix-p ".patch" filename t)))
> +           (with-temp-buffer
> +             (mm-display-inline handle)
> +             (cons
> +              (string-to-number filename)
> +              (buffer-substring-no-properties (point-min) (point-max))))))))

Why using (and ...)? It feels like (when ...) is more appropriate in
this context.

Best,
Ihor