From: Kyle Meyer <firstname.lastname@example.org>
To: Ihor Radchenko <email@example.com>
Subject: Re: [PATCH] piem-am: Order attached patches by file name prefix
Date: Sun, 10 Jul 2022 10:25:25 -0400 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Ihor Radchenko writes:
> Kyle Meyer <email@example.com> writes:
>> If you're commenting more generally on the _code_ of
>> piem-gnus-am-ready-mbox and piem-notmuch-am-ready-mbox, I'm open to
>> suggestions for extracting out any remaining shared bits, but my hunch
>> is that most directions would obscure things.
> I referred to both code and the docstring.
> I'd define a separate function that inserts am-ready mbox:
As you can probably guess from my last sentence, I don't think
maintaining that extra level of indirection in piem.el buys enough to be
worth the decrease in readability. But that's of course a judgment
> I do agree that using side-effects inside `and' is confusing and `when'
> should be preferred.
> However, we are talking about an opposite situation here.
> No side effects and we intend to provide a return value.
> The cites style convention does not necessarily apply in reverse except
> that `when' should not ideally be used.
I'm not claiming it's symmetric: I mentioned cases where I prefer `and
-> when`, but you're right that that doesn't go in the other direction.
So I agree with what you say here, as far as I can see.
> When choosing between `and' and `if' I personally also dislike using
> (and condition1 condition2 ... return-value)
My tastes don't align with yours here.
> Of course, this is a very minor stylistic comment - [...]
Of course. Thanks for taking the time to expand on your opinion.
prev parent reply other threads:[~2022-07-10 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 3:11 [BUG] Patch order is not respected for sequence of patches like [PATCH X/Y] Ihor Radchenko
2022-07-09 6:45 ` [PATCH] piem-am: Order attached patches by file name prefix Kyle Meyer
2022-07-09 7:38 ` Ihor Radchenko
2022-07-09 16:56 ` Kyle Meyer
2022-07-10 9:59 ` Ihor Radchenko
2022-07-10 14:25 ` Kyle Meyer [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).