Re: [PATCH] notmuch: Configure mailing list archive links

[Xinglu Chen <public@yoctocell.xyz>]

On Fri, Feb 05 2021, Kyle Meyer wrote:

>   * What about in cases where there is no inbox/url?  Right now it would
>     just return the plain message ID.  Should it signal a user-error
>     instead?

It should probably give an error and maybe tell the user to add a url.

>> +
>>  ;;;###autoload
>>  (define-minor-mode piem-notmuch-mode
>>    "Toggle Notmuch support for piem.
>> @@ -119,11 +126,18 @@ (define-minor-mode piem-notmuch-mode
>>          (add-hook 'piem-am-ready-mbox-functions #'piem-notmuch-am-ready-mbox)
>>          (add-hook 'piem-get-inbox-functions #'piem-notmuch-get-inbox)
>>          (add-hook 'piem-get-mid-functions #'piem-notmuch-get-mid)
>> -        (add-hook 'piem-mid-to-thread-functions #'piem-notmuch-mid-to-thread))
>> +        (add-hook 'piem-mid-to-thread-functions #'piem-notmuch-mid-to-thread)
>> +        (add-to-list 'notmuch-show-stash-mlarchive-link-alist
>> +                     '("piem" . piem-notmuch-show-get-public-inbox-link))
>> +        (setq notmuch-show-stash-mlarchive-link-default "piem"))
>
> I'd rather not override the user's
> notmuch-show-stash-mlarchive-link-default setting (even if we were to
> only do so for the default value of "Gmane", which we know is
> nonfunctional and not likely coming back at this point).  Instead, how
> about just mentioning notmuch-show-stash-mlarchive-link support in
> piem-notmuch-mode's docstring along with a suggestion to set
> notmuch-show-stash-mlarchive-link-default to "piem"?

That sounds like a better idea than what I am currently doing.