discussion and development of piem
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH] notmuch: Configure mailing list archive links
Date: Sat, 06 Feb 2021 09:07:18 +0100	[thread overview]
Message-ID: <878s81mxft.fsf@yoctocell.xyz> (raw)
In-Reply-To: <878s81kd8u.fsf@kyleam.com>

On Fri, Feb 05 2021, Kyle Meyer wrote:

>   * What about in cases where there is no inbox/url?  Right now it would
>     just return the plain message ID.  Should it signal a user-error
>     instead?

It should probably give an error and maybe tell the user to add a url.

>> +
>>  ;;;###autoload
>>  (define-minor-mode piem-notmuch-mode
>>    "Toggle Notmuch support for piem.
>> @@ -119,11 +126,18 @@ (define-minor-mode piem-notmuch-mode
>>          (add-hook 'piem-am-ready-mbox-functions #'piem-notmuch-am-ready-mbox)
>>          (add-hook 'piem-get-inbox-functions #'piem-notmuch-get-inbox)
>>          (add-hook 'piem-get-mid-functions #'piem-notmuch-get-mid)
>> -        (add-hook 'piem-mid-to-thread-functions #'piem-notmuch-mid-to-thread))
>> +        (add-hook 'piem-mid-to-thread-functions #'piem-notmuch-mid-to-thread)
>> +        (add-to-list 'notmuch-show-stash-mlarchive-link-alist
>> +                     '("piem" . piem-notmuch-show-get-public-inbox-link))
>> +        (setq notmuch-show-stash-mlarchive-link-default "piem"))
> I'd rather not override the user's
> notmuch-show-stash-mlarchive-link-default setting (even if we were to
> only do so for the default value of "Gmane", which we know is
> nonfunctional and not likely coming back at this point).  Instead, how
> about just mentioning notmuch-show-stash-mlarchive-link support in
> piem-notmuch-mode's docstring along with a suggestion to set
> notmuch-show-stash-mlarchive-link-default to "piem"?

That sounds like a better idea than what I am currently doing.

  reply	other threads:[~2021-02-06  8:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 17:10 [PATCH] notmuch: Configure mailing list archive links Xinglu Chen
2021-02-06  4:54 ` Kyle Meyer
2021-02-06  8:07   ` Xinglu Chen [this message]
2021-02-06  8:44 ` [PATCH v2] " Xinglu Chen
2021-02-06 15:58   ` Kyle Meyer
2021-02-06 16:17     ` Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s81mxft.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).