From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <public@yoctocell.xyz>
Received: from mp1 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms12 with LMTPS
	id yByYCj5OHmDJegAAsNZ9tg
	(envelope-from <public@yoctocell.xyz>)
	for <larch@inbox.kyleam.com>; Sat, 06 Feb 2021 08:07:26 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp1 with LMTPS
	id yIRJNztOHmA1cQAAbx9fmQ
	(envelope-from <public@yoctocell.xyz>)
	for <larch@inbox.kyleam.com>; Sat, 06 Feb 2021 08:07:23 +0000
Received: from mail.yoctocell.xyz (h87-96-130-155.cust.a3fiber.se [87.96.130.155])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id C7F149401C0
	for <piem@inbox.kyleam.com>; Sat,  6 Feb 2021 08:07:20 +0000 (UTC)
From: Xinglu Chen <public@yoctocell.xyz>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz;
	s=mail; t=1612598838;
	bh=IdHom0ICuBW1ndNYYRLnVfCLFbNL7cb6JHIsZMPSkWk=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=jwFkSgH7Q+mcug+tvL920Bs43aBPGBmSU6AL9DqKJ9/dZYf0f4OmBFIJwaGmzAlaQ
	 gVtjdAqzlmQ5Jsw5MgrSHP1wh2KctdhO9GMumXnxmp9/LRGx8ZjVRm1bZnvyIjjd7D
	 ZvmoNkdgtSuD7ol9tw5+OWAnumDHsvPJSiJrXtks=
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH] notmuch: Configure mailing list archive links
In-Reply-To: <878s81kd8u.fsf@kyleam.com>
References: <2ffe23775ec008feb763e24c29786fc5feddb975.1612544763.git.public@yoctocell.xyz>
 <878s81kd8u.fsf@kyleam.com>
Date: Sat, 06 Feb 2021 09:07:18 +0100
Message-ID: <878s81mxft.fsf@yoctocell.xyz>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_IN
X-Migadu-Spam-Score: -4.00
Authentication-Results: aspmx1.migadu.com;
	none
X-Migadu-Queue-Id: C7F149401C0
X-Spam-Score: -4.00
X-Migadu-Scanner: scn1.migadu.com
X-TUID: oog/CCYziHnn

On Fri, Feb 05 2021, Kyle Meyer wrote:

>   * What about in cases where there is no inbox/url?  Right now it would
>     just return the plain message ID.  Should it signal a user-error
>     instead?

It should probably give an error and maybe tell the user to add a url.

>> +
>>  ;;;###autoload
>>  (define-minor-mode piem-notmuch-mode
>>    "Toggle Notmuch support for piem.
>> @@ -119,11 +126,18 @@ (define-minor-mode piem-notmuch-mode
>>          (add-hook 'piem-am-ready-mbox-functions #'piem-notmuch-am-ready-mbox)
>>          (add-hook 'piem-get-inbox-functions #'piem-notmuch-get-inbox)
>>          (add-hook 'piem-get-mid-functions #'piem-notmuch-get-mid)
>> -        (add-hook 'piem-mid-to-thread-functions #'piem-notmuch-mid-to-thread))
>> +        (add-hook 'piem-mid-to-thread-functions #'piem-notmuch-mid-to-thread)
>> +        (add-to-list 'notmuch-show-stash-mlarchive-link-alist
>> +                     '("piem" . piem-notmuch-show-get-public-inbox-link))
>> +        (setq notmuch-show-stash-mlarchive-link-default "piem"))
>
> I'd rather not override the user's
> notmuch-show-stash-mlarchive-link-default setting (even if we were to
> only do so for the default value of "Gmane", which we know is
> nonfunctional and not likely coming back at this point).  Instead, how
> about just mentioning notmuch-show-stash-mlarchive-link support in
> piem-notmuch-mode's docstring along with a suggestion to set
> notmuch-show-stash-mlarchive-link-default to "piem"?

That sounds like a better idea than what I am currently doing.