discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [RFC PATCH 04/14] am: Add function for reading piem-am's arguments
Date: Wed, 29 Dec 2021 18:50:26 -0500	[thread overview]
Message-ID: <20211229235036.372313-5-kyle@kyleam.com> (raw)
In-Reply-To: <20211229235036.372313-1-kyle@kyleam.com>

Another command will need to do very similar processing.
---
 piem.el | 34 ++++++++++++++++------------------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/piem.el b/piem.el
index 4b0457a2..dc93f89d 100644
--- a/piem.el
+++ b/piem.el
@@ -933,6 +933,20 @@ (defun piem--git-am (mbox format dir)
       (magit-status-setup-buffer dir)
     (dired dir)))
 
+(defun piem-am--arguments ()
+  (pcase-let ((`(,mbox . ,format)
+               (or (piem-am-ready-mbox)
+                   (user-error
+                    "Could not find am-ready mbox for current buffer"))))
+    ;; We're responsible for cleaning up the buffer created by
+    ;; `piem-am-ready-mbox'; sneak in an indication to let the
+    ;; downstream code know.
+    (list (cons :interactive mbox)
+          format
+          (piem-extract-mbox-info mbox)
+          (piem-inbox-coderepo-maybe-read)
+          current-prefix-arg)))
+
 ;;;###autoload
 (defun piem-am (mbox &optional format info coderepo toggle-worktree)
   "Feed an am-ready mbox to `git am'.
@@ -953,26 +967,10 @@ (defun piem-am (mbox &optional format info coderepo toggle-worktree)
 When prefix argument TOGGLE-WORKTREE is non-nil, invert the
 meaning of `piem-am-create-worktree'.  With the default value,
 this triggers the creation of a new worktree."
-  (interactive
-   (pcase-let ((`(,mbox . ,format)
-                (or (piem-am-ready-mbox)
-                    (user-error
-                     "Could not find am-ready mbox for current buffer"))))
-     ;; We're responsible for cleaning up the buffer created by
-     ;; `piem-am-ready-mbox'; sneak in an indication to let the
-     ;; downstream code know.
-     (list (cons :interactive mbox)
-           format
-           (piem-extract-mbox-info mbox)
-           (piem-inbox-coderepo-maybe-read)
-           current-prefix-arg)))
-  (setq format (or format "mboxrd"))
+  (interactive (piem-am--arguments))
   (let* ((default-directory (or coderepo default-directory))
          (am-directory default-directory)
-         (use-worktree (xor piem-am-create-worktree toggle-worktree))
-         (interactivep (eq (car-safe mbox) :interactive)))
-    (when interactivep
-      (setq mbox (cdr mbox)))
+         (use-worktree (xor piem-am-create-worktree toggle-worktree)))
     (let ((new-branch
            (let ((b (read-string "New branch (empty for detached): "
                                  (funcall piem-default-branch-function info))))
-- 
2.34.0


  parent reply	other threads:[~2021-12-29 23:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 23:50 [RFC PATCH 00/14] am, b4-am: Add commands to extend an existing branch Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 01/14] am: Give better name to default piem-am-read-worktree-function value Kyle Meyer
2022-02-05 17:37   ` Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 02/14] am: Add dedicated function for reading worktree Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 03/14] am: Extract git-am logic to dedicated function Kyle Meyer
2021-12-29 23:50 ` Kyle Meyer [this message]
2021-12-29 23:50 ` [RFC PATCH 05/14] am: Add comment header for patch editing subsection Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 06/14] edit patch: Inject values via interactive arguments Kyle Meyer
2022-02-05 17:48   ` Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 07/14] am, b4-am: Rename piem-am to piem-am-create Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 08/14] am, b4-am: Rewrite -create docstrings to emphasize branch creation Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 09/14] piem-am-create: Move info argument to the end Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 10/14] piem-am--arguments: Make info extraction optional Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 11/14] b4: Move logic for checking arguments to a dedicated function Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 12/14] am, b4-am: Add commands that extend an existing branch Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 13/14] am: Move functionality under a dedicated transient Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 14/14] b4: Add piem-b4-am-from-mid-extend to transient Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211229235036.372313-5-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [RFC PATCH 04/14] am: Add function for reading piem-am'\''s arguments' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).