discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [RFC PATCH 11/14] b4: Move logic for checking arguments to a dedicated function
Date: Wed, 29 Dec 2021 18:50:33 -0500	[thread overview]
Message-ID: <20211229235036.372313-12-kyle@kyleam.com> (raw)
In-Reply-To: <20211229235036.372313-1-kyle@kyleam.com>

The new -extend variant will need to do the same check.
---
 piem-b4.el | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/piem-b4.el b/piem-b4.el
index d2370124..48836eb2 100644
--- a/piem-b4.el
+++ b/piem-b4.el
@@ -127,6 +127,17 @@ (defun piem-b4-am-ready-from-mid (mid &optional args)
   (apply #'piem-process-start nil piem-b4-b4-executable "am"
          (append args (list mid))))
 
+(defun piem-b4-am--check-args (args)
+  (when-let ((badopt (cl-some
+                      (lambda (arg)
+                        (and (string-match
+                              (rx string-start
+                                  (group (or "--outdir" "--mbox-name")) "=")
+                              arg)
+                             (match-string 1 arg)))
+                      args)))
+    (user-error "%s is incompatible with this command" badopt)))
+
 ;;;###autoload
 (defun piem-b4-am-from-mid-create (mid &optional args toggle-worktree)
   "Create a new branch with patches extracted from MID's thread.
@@ -148,15 +159,7 @@ (defun piem-b4-am-from-mid-create (mid &optional args toggle-worktree)
                          (read-string "Message ID: "))
                      (transient-args 'piem-b4-am)
                      current-prefix-arg))
-  (when-let ((badopt (cl-some
-                      (lambda (arg)
-                        (and (string-match
-                              (rx string-start
-                                  (group (or "--outdir" "--mbox-name")) "=")
-                              arg)
-                             (match-string 1 arg)))
-                      args)))
-    (user-error "%s is incompatible with this command" badopt))
+  (piem-b4-am--check-args args)
   (pcase-let* ((coderepo (piem-inbox-coderepo-maybe-read))
                (`(,cover ,mbox-file ,clean-fn)
                 (piem-b4--get-am-files mid coderepo args))
-- 
2.34.0


  parent reply	other threads:[~2021-12-29 23:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 23:50 [RFC PATCH 00/14] am, b4-am: Add commands to extend an existing branch Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 01/14] am: Give better name to default piem-am-read-worktree-function value Kyle Meyer
2022-02-05 17:37   ` Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 02/14] am: Add dedicated function for reading worktree Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 03/14] am: Extract git-am logic to dedicated function Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 04/14] am: Add function for reading piem-am's arguments Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 05/14] am: Add comment header for patch editing subsection Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 06/14] edit patch: Inject values via interactive arguments Kyle Meyer
2022-02-05 17:48   ` Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 07/14] am, b4-am: Rename piem-am to piem-am-create Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 08/14] am, b4-am: Rewrite -create docstrings to emphasize branch creation Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 09/14] piem-am-create: Move info argument to the end Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 10/14] piem-am--arguments: Make info extraction optional Kyle Meyer
2021-12-29 23:50 ` Kyle Meyer [this message]
2021-12-29 23:50 ` [RFC PATCH 12/14] am, b4-am: Add commands that extend an existing branch Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 13/14] am: Move functionality under a dedicated transient Kyle Meyer
2021-12-29 23:50 ` [RFC PATCH 14/14] b4: Add piem-b4-am-from-mid-extend to transient Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211229235036.372313-12-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).