discussion and development of piem
 help / color / mirror / code / Atom feed
From: sourcehut@relevant-information.com
To: piem@inbox.kyleam.com
Cc: Leo <sourcehut@relevant-information.com>
Subject: [PATCH 1/1] Use notmuch-extract-patch if available
Date: Thu,  9 Dec 2021 21:43:19 +0100	[thread overview]
Message-ID: <20211209204319.168897-2-sourcehut@relevant-information.com> (raw)
In-Reply-To: <20211209204319.168897-1-sourcehut@relevant-information.com>

From: Leo <sourcehut@relevant-information.com>

notmuch-extract-patch is a command line tool from the elpa-mailscripts
package that extracts patches from a thread. It's a useful way to
extract the latest patch series from an email thread and filter out the
replies and reviews.
---
 piem-notmuch.el | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/piem-notmuch.el b/piem-notmuch.el
index 8b2a353..05c03ab 100644
--- a/piem-notmuch.el
+++ b/piem-notmuch.el
@@ -81,7 +81,9 @@ (defun piem-notmuch-am-ready-mbox ()
   "Return a function that inserts an am-ready mbox.
 If the buffer has any MIME parts that look like a patch, use
 those parts' contents (in order) as the mbox.  Otherwise, use the
-message itself if it looks like a patch."
+message itself if it looks like a patch. If the executable
+notmuch-extract-patch exists on the path, use that to get the
+latest patch series from the notmuch thread."
   (when (derived-mode-p 'notmuch-show-mode)
     (let* ((handle (piem-notmuch--with-current-message
                      (mm-dissect-buffer)))
@@ -90,10 +92,25 @@ (defun piem-notmuch-am-ready-mbox ()
       (if (= n-attachments 0)
           (when (string-match-p piem-patch-subject-re
                                 (notmuch-show-get-subject))
-            (let ((id (notmuch-show-get-message-id)))
+            (let ((id (notmuch-show-get-message-id))
+                  (thread-id notmuch-show-thread-id))
               (lambda ()
-                (call-process notmuch-command nil t nil
-                              "show" "--format=mbox" id))))
+                (if-let ((cmd (executable-find "notmuch-extract-patch"))
+                         (tid
+                          ;; If `notmuch-show' was called with a notmuch query rather
+                          ;; than a thread ID, as `org-notmuch-follow-link' in
+                          ;; org-notmuch.el does, then `notmuch-show-thread-id' might
+                          ;; be an arbitrary notmuch query instead of a thread ID.  We
+                          ;; need to wrap such a query in thread:{} before passing it
+                          ;; to notmuch-extract-patch(1), or we might not get a whole
+                          ;; thread extracted (e.g. if the query is just id:foo)
+                          (if (string= (substring thread-id 0 7) "thread:")
+                              thread-id
+                            (concat "thread:{" thread-id "}"))))
+                    (call-process cmd nil t nil
+                                  tid)
+                  (call-process notmuch-command nil t nil
+                                "show" "--format=mbox" id)))))
         (notmuch-foreach-mime-part
          (lambda (p)
            (when-let ((patch (piem-am-extract-attached-patch p)))
-- 
2.31.0


  reply	other threads:[~2021-12-09 20:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 20:43 [PATCH 0/1] Use notmuch-extract-patch if available sourcehut
2021-12-09 20:43 ` sourcehut [this message]
2021-12-11 21:44   ` [PATCH 1/1] " Kyle Meyer
2021-12-12  9:44     ` Leo
2021-12-12 18:45       ` Kyle Meyer
2021-12-12 19:33         ` Sean Whitton
2021-12-12 19:49           ` Kyle Meyer
2021-12-14 19:12             ` Sean Whitton
2021-12-13 11:45           ` Leo
2021-12-14 11:36     ` Leo
2021-12-20  6:45       ` Sean Whitton
2021-12-12 19:26   ` Sean Whitton
2021-12-13 11:53     ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211209204319.168897-2-sourcehut@relevant-information.com \
    --to=sourcehut@relevant-information.com \
    --cc=piem@inbox.kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).