Re: [PATCH 1/1] Use notmuch-extract-patch if available

[Sean Whitton <spwhitton@spwhitton.name>]

Hello,

On Tue 14 Dec 2021 at 12:36PM +01, Leo wrote:

> Kyle Meyer <kyle@kyleam.com> writes:
>
>> sourcehut@relevant-information.com writes:
>>> +                (if-let ((cmd (executable-find "notmuch-extract-patch"))
>>> +                         (tid
>>> +                          ;; If `notmuch-show' was called with a notmuch query rather
>>> +                          ;; than a thread ID, as `org-notmuch-follow-link' in
>>> +                          ;; org-notmuch.el does, then `notmuch-show-thread-id' might
>>> +                          ;; be an arbitrary notmuch query instead of a thread ID.  We
>>> +                          ;; need to wrap such a query in thread:{} before passing it
>>> +                          ;; to notmuch-extract-patch(1), or we might not get a whole
>>> +                          ;; thread extracted (e.g. if the query is just id:foo)
>>> +                          (if (string= (substring thread-id 0 7) "thread:")
>>> +                              thread-id
>>> +                            (concat "thread:{" thread-id "}"))))
>>
>> I believe this comment and (if ...) is coming straight from
>> mailscripts.el.  You note in the cover letter that some of this is
>> copied from mailscripts.el, but I think there should be a code comment
>> as well.
>>
>> However, I don't really understand why the condition is necessary.
>> Wouldn't always using
>>
>>   thread:{notmuch-show-get-message-id return value}
>>
>> work?
>
> I don't actually know, maybe Sean Whitton knows?

I guess if you are using the function notmuch-show-get-message-id rather
than the variable notmuch-show-thread-id, then it sounds like just
wrapping that in thread:{} would work.  But it has been some years since
I figured out that code, I'm afraid.

-- 
Sean Whitton