discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH 2/4] piem-inbox-coderepo*: Always return coderepo as a directory
Date: Thu, 10 Jun 2021 14:59:41 -0400	[thread overview]
Message-ID: <20210610185943.14155-3-kyle@kyleam.com> (raw)
In-Reply-To: <20210610185943.14155-1-kyle@kyleam.com>

A coderepo is by definition a directory.  Append a trailing separator
so that callers don't have to worry about normalizing it.
---
 piem.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/piem.el b/piem.el
index 0efae9ef..65466150 100644
--- a/piem.el
+++ b/piem.el
@@ -376,7 +376,7 @@ (defun piem-inbox-get (key &optional inbox)
 (defun piem-inbox-coderepo (&optional inbox)
   "Return the code repository of current buffer's inbox."
   (when-let ((repo (piem-inbox-get :coderepo inbox)))
-    (expand-file-name repo)))
+    (file-name-as-directory (expand-file-name repo))))
 
 (defun piem-inbox-maildir-directory (&optional inbox)
   "Return the maildir for INBOX's entry in `piem-inboxes'.
@@ -421,7 +421,7 @@ (defun piem-inbox-coderepo-maybe-read ()
              (read-directory-name "Git repository: "))))
     (if (equal repo "")
         (user-error "No code repository specified")
-      repo)))
+      (file-name-as-directory repo))))
 
 (defun piem-mid ()
   "Return the current buffer's message ID."
-- 
2.32.0


  parent reply	other threads:[~2021-06-10 18:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 18:59 [PATCH 0/4] Support reading inboxes from ~/.public-inbox/config Kyle Meyer
2021-06-10 18:59 ` [PATCH 1/4] piem-inbox-coderepo-maybe-read: Avoid confusing "inbox" references Kyle Meyer
2021-06-10 18:59 ` Kyle Meyer [this message]
2021-06-10 18:59 ` [PATCH 3/4] piem-inboxes: Clarify that :coderepo points to a working tree Kyle Meyer
2021-06-10 18:59 ` [PATCH 4/4] Support reading inboxes from ~/.public-inbox/config Kyle Meyer
2021-06-10 19:32   ` Xinglu Chen
2021-06-10 21:00     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610185943.14155-3-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [PATCH 2/4] piem-inbox-coderepo*: Always return coderepo as a directory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).