discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH 1/4] piem-inbox-coderepo-maybe-read: Avoid confusing "inbox" references
Date: Thu, 10 Jun 2021 14:59:40 -0400	[thread overview]
Message-ID: <20210610185943.14155-2-kyle@kyleam.com> (raw)
In-Reply-To: <20210610185943.14155-1-kyle@kyleam.com>

piem-inbox-coderepo-maybe-read deals with a code repository but
confusingly calls it "inbox".
 piem.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/piem.el b/piem.el
index 0b39efb4..0efae9ef 100644
--- a/piem.el
+++ b/piem.el
@@ -400,7 +400,7 @@ (defun piem-inbox-by-url-match (url)
 (defun piem-inbox-coderepo-maybe-read ()
   "Like `piem-inbox-coderepo', but fall back to reading the repo."
-  (let ((inbox
+  (let ((repo
          (or (piem-inbox-coderepo)
              (and (bound-and-true-p projectile-known-projects)
@@ -419,9 +419,9 @@ (defun piem-inbox-coderepo-maybe-read ()
                   (fboundp 'magit-read-repository)
              (read-directory-name "Git repository: "))))
-    (if (equal inbox "")
-        (user-error "No inbox specified")
-      inbox)))
+    (if (equal repo "")
+        (user-error "No code repository specified")
+      repo)))
 (defun piem-mid ()
   "Return the current buffer's message ID."

  reply	other threads:[~2021-06-10 18:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 18:59 [PATCH 0/4] Support reading inboxes from ~/.public-inbox/config Kyle Meyer
2021-06-10 18:59 ` Kyle Meyer [this message]
2021-06-10 18:59 ` [PATCH 2/4] piem-inbox-coderepo*: Always return coderepo as a directory Kyle Meyer
2021-06-10 18:59 ` [PATCH 3/4] piem-inboxes: Clarify that :coderepo points to a working tree Kyle Meyer
2021-06-10 18:59 ` [PATCH 4/4] Support reading inboxes from ~/.public-inbox/config Kyle Meyer
2021-06-10 19:32   ` Xinglu Chen
2021-06-10 21:00     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610185943.14155-2-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).