discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH 12/18] piem-lei-query-thread: Add bug#NNN special case when eliding subject
Date: Sat,  5 Jun 2021 17:13:56 -0400	[thread overview]
Message-ID: <20210605211402.20304-13-kyle@kyleam.com> (raw)
In-Reply-To: <20210605211402.20304-1-kyle@kyleam.com>

In debbugs threads, it's not uncommon for a leading "[bug#NNN]" in the
subject to be converted to "bug#NNN:" [*].  I'm not sure what the
source of this is, but it prevents the suppression of an otherwise
identical subject.

It's probably not worth normalizing before the comparison to get full
suppression, but it'd be nice to at least elide the main part of the
subject so it's more obvious that it didn't change.  Add a special
case so that "bug#NNN:" prefix is treated the same as a bracketed
prefix.

[*] example:
    https://yhetil.org/guix-patches/20201128051435.30580-1-kyle@kyleam.com
---

   My guess, which I haven't tried to confirm at all, is that the
   "[bug#NNN]" => "bug#NNN:" conversion is triggered via the
   debbugs.el interface.

 piem-lei.el             | 14 ++++++++++++--
 tests/piem-lei-tests.el |  6 +++++-
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/piem-lei.el b/piem-lei.el
index f7ccc6e4..3760176c 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -345,8 +345,18 @@ (defvar piem-lei-query--subject-split-re
   (rx string-start
       ;; Prefix.
       (group (zero-or-more space)
-             (one-or-more "[" (one-or-more (not (any "]" "\n"))) "]"
-                          (one-or-more space)))
+             (or (and (one-or-more (and "bug#" (one-or-more digit) ":"))
+                      (one-or-more space)
+                      (zero-or-more
+                       ;; This pattern...
+                       "[" (one-or-more (not (any "]" "\n"))) "]"
+                       (one-or-more space)))
+                 (one-or-more
+                  ;; ... is repeated here.  Extract it to an rx-let
+                  ;; binding once minimum Emacs version is at least
+                  ;; 27.
+                  "[" (one-or-more (not (any "]" "\n"))) "]"
+                  (one-or-more space))))
       ;; Main subject.  A match consists of at least two islands of
       ;; non-space characters because there's not much point in
       ;; eliding one word.
diff --git a/tests/piem-lei-tests.el b/tests/piem-lei-tests.el
index 71dc1099..dd58360b 100644
--- a/tests/piem-lei-tests.el
+++ b/tests/piem-lei-tests.el
@@ -110,7 +110,11 @@ (ert-deftest piem-lei-query--elide-subject:elide ()
   (should (equal (concat "[bug#00000] [PATCH v2] " piem-lei-tests-elide-string)
                  (piem-lei-query--elide-subject
                   "[bug#00000] [PATCH] abc def"
-                  "[bug#00000] [PATCH v2] abc def"))))
+                  "[bug#00000] [PATCH v2] abc def")))
+  (should (equal (concat "bug#00000: [PATCH v2] " piem-lei-tests-elide-string)
+                 (piem-lei-query--elide-subject
+                  "[bug#00000] [PATCH] abc def"
+                  "bug#00000: [PATCH v2] abc def"))))
 
 (provide 'piem-lei-tests)
 ;;; piem-lei-tests.el ends here
-- 
2.31.1


  parent reply	other threads:[~2021-06-05 21:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-05 21:13 [PATCH 00/18] Initial lei support Kyle Meyer
2021-06-05 21:13 ` [PATCH 01/18] lei: Add command and mode for displaying a message Kyle Meyer
2021-06-05 21:13 ` [PATCH 02/18] piem-lei-show: Let caller suppress displaying buffer Kyle Meyer
2021-06-05 21:13 ` [PATCH 03/18] piem-lei-show: Highlight headers and quoted text Kyle Meyer
2021-06-05 21:13 ` [PATCH 04/18] lei: Add command and mode for displaying overview of search results Kyle Meyer
2021-06-05 21:13 ` [PATCH 05/18] lei query: Add piem-lei-show wrapper for displaying line's message Kyle Meyer
2021-06-05 21:13 ` [PATCH 06/18] lei: Add command for viewing a thread Kyle Meyer
2021-06-05 21:13 ` [PATCH 07/18] lei query: Fontify results Kyle Meyer
2021-06-05 21:13 ` [PATCH 08/18] piem-lei-query-thread: Position point on seed message Kyle Meyer
2021-06-05 21:13 ` [PATCH 09/18] piem-lei-query-thread: Drop repeated subjects Kyle Meyer
2021-06-05 21:13 ` [PATCH 10/18] piem-lei-query-thread: Deal with multiple "re:"s Kyle Meyer
2021-06-05 21:13 ` [PATCH 11/18] piem-lei-query-thread: Omit main part of subject if shared Kyle Meyer
2021-06-05 21:13 ` Kyle Meyer [this message]
2021-06-05 21:13 ` [PATCH 13/18] lei query: Add next/previous line variants that update message buffer Kyle Meyer
2021-06-05 21:13 ` [PATCH 14/18] piem-lei-show: Record message ID Kyle Meyer
2021-06-05 21:13 ` [PATCH 15/18] lei query: Add commands for showing or scrolling message buffer Kyle Meyer
2021-06-05 21:14 ` [PATCH 16/18] lei: Configure bindings for query and show modes Kyle Meyer
2021-06-05 21:14 ` [PATCH 17/18] lei: Wire up piem.el hooks Kyle Meyer
2021-06-05 21:14 ` [PATCH 18/18] piem-lei-query-thread: Use piem-lei-get-mid to get message ID Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210605211402.20304-13-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [PATCH 12/18] piem-lei-query-thread: Add bug#NNN special case when eliding subject' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).