discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH 09/18] piem-lei-query-thread: Drop repeated subjects
Date: Sat,  5 Jun 2021 17:13:53 -0400	[thread overview]
Message-ID: <20210605211402.20304-10-kyle@kyleam.com> (raw)
In-Reply-To: <20210605211402.20304-1-kyle@kyleam.com>

public-inbox's web interface suppresses a message's subject when it
matches the previous lines [*].  Teach piem-lei-query-thread to do the
same to make it easier to spot subject shifts and identify subthreads.

[*] notmuch-tree-mode does similar, displaying "..." instead.
---
 piem-lei.el | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/piem-lei.el b/piem-lei.el
index 74bf357e..43ab01ee 100644
--- a/piem-lei.el
+++ b/piem-lei.el
@@ -370,7 +370,7 @@ (defun piem-lei-query-thread (mid)
   (let* ((records (piem-lei-query--slurp
                    (list "--threads" (concat "m:" mid))))
          (msgs (piem-lei-query--thread records))
-         depths pt-final)
+         depths pt-final subject-prev)
     (with-current-buffer (get-buffer-create "*lei-thread*")
       (let ((inhibit-read-only t))
         (erase-buffer)
@@ -384,25 +384,34 @@ (defun piem-lei-query-thread (mid)
               (setq msgs (append children msgs)))
             (push (cons msg depth) depths)
             (if (not (piem-lei-msg-ghost msg))
-                (let ((data (cdr (assoc mid-msg records))))
+                (let* ((data (cdr (assoc mid-msg records)))
+                       (subject (let ((case-fold-search t))
+                                  (replace-regexp-in-string
+                                   (rx string-start "re:" (one-or-more space))
+                                   ""
+                                   (string-trim (cdr (assq 's data)))))))
                   (insert
                    (piem-lei-query--format-date data) " "
                    (piem-lei-query--format-thread-marker depth)
                    (let ((from (car (cdr (assq 'f data)))))
                      (propertize (or (car from) (cadr from))
                                  'font-lock-face 'piem-lei-query-from))
-                   (concat "  "
-                           (propertize (cdr (assq 's data))
-                                       'font-lock-face
-                                       'piem-lei-query-subject)))
+                   (if (equal subject subject-prev)
+                       ""
+                     (concat "  "
+                             (propertize subject
+                                         'font-lock-face
+                                         'piem-lei-query-subject))))
                   (add-text-properties (line-beginning-position)
                                        (line-end-position)
-                                       (list 'piem-lei-query-result data)))
+                                       (list 'piem-lei-query-result data))
+                  (setq subject-prev subject))
               (insert (make-string 17 ?\s) ; Date alignment.
                       (piem-lei-query--format-thread-marker depth)
                       (propertize (concat " <" mid-msg ">")
                                   'font-lock-face
-                                  'piem-lei-query-thread-ghost)))
+                                  'piem-lei-query-thread-ghost))
+              (setq subject-prev nil))
             (when (equal mid-msg mid)
               (setq pt-final (line-beginning-position)))
             (insert ?\n)))
-- 
2.31.1


  parent reply	other threads:[~2021-06-05 21:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-05 21:13 [PATCH 00/18] Initial lei support Kyle Meyer
2021-06-05 21:13 ` [PATCH 01/18] lei: Add command and mode for displaying a message Kyle Meyer
2021-06-05 21:13 ` [PATCH 02/18] piem-lei-show: Let caller suppress displaying buffer Kyle Meyer
2021-06-05 21:13 ` [PATCH 03/18] piem-lei-show: Highlight headers and quoted text Kyle Meyer
2021-06-05 21:13 ` [PATCH 04/18] lei: Add command and mode for displaying overview of search results Kyle Meyer
2021-06-05 21:13 ` [PATCH 05/18] lei query: Add piem-lei-show wrapper for displaying line's message Kyle Meyer
2021-06-05 21:13 ` [PATCH 06/18] lei: Add command for viewing a thread Kyle Meyer
2021-06-05 21:13 ` [PATCH 07/18] lei query: Fontify results Kyle Meyer
2021-06-05 21:13 ` [PATCH 08/18] piem-lei-query-thread: Position point on seed message Kyle Meyer
2021-06-05 21:13 ` Kyle Meyer [this message]
2021-06-05 21:13 ` [PATCH 10/18] piem-lei-query-thread: Deal with multiple "re:"s Kyle Meyer
2021-06-05 21:13 ` [PATCH 11/18] piem-lei-query-thread: Omit main part of subject if shared Kyle Meyer
2021-06-05 21:13 ` [PATCH 12/18] piem-lei-query-thread: Add bug#NNN special case when eliding subject Kyle Meyer
2021-06-05 21:13 ` [PATCH 13/18] lei query: Add next/previous line variants that update message buffer Kyle Meyer
2021-06-05 21:13 ` [PATCH 14/18] piem-lei-show: Record message ID Kyle Meyer
2021-06-05 21:13 ` [PATCH 15/18] lei query: Add commands for showing or scrolling message buffer Kyle Meyer
2021-06-05 21:14 ` [PATCH 16/18] lei: Configure bindings for query and show modes Kyle Meyer
2021-06-05 21:14 ` [PATCH 17/18] lei: Wire up piem.el hooks Kyle Meyer
2021-06-05 21:14 ` [PATCH 18/18] piem-lei-query-thread: Use piem-lei-get-mid to get message ID Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210605211402.20304-10-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [PATCH 09/18] piem-lei-query-thread: Drop repeated subjects' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).