discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH 2/2] piem-use-magit: Unconditionally set to t
Date: Sat, 22 May 2021 16:39:05 -0400	[thread overview]
Message-ID: <20210522203905.16504-3-kyle@kyleam.com> (raw)
In-Reply-To: <20210522203905.16504-1-kyle@kyleam.com>

When piem is loaded, piem-use-magit is enabled if Magit has already
been loaded.  This approach is potentially confusing: a user may want
to use Magit, be happy that it seems to just work, and then confused
when it doesn't work in some later session where loading Magit happens
to not be triggered before loading piem.

All the relevant sites have fboundp guards (and those are cheap), so
there's no advantage to disabling this if Magit isn't enabled at load
time.  Set piem-use-magit to t by default.
 Documentation/piem.texi | 9 ++++-----
 piem.el                 | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/Documentation/piem.texi b/Documentation/piem.texi
index 0f5235c..ca6a97b 100644
--- a/Documentation/piem.texi
+++ b/Documentation/piem.texi
@@ -265,11 +265,10 @@ Applying patches contained in a message
 @cindex magit
 @vindex piem-use-magit
-When piem loads, it detects whether Magit is loaded and sets
-@code{piem-use-magit} accordingly.  If that option is non-nil, piem uses
-Magit for some operations, particularly those that are user-facing.
-This includes jumping to the Magit status buffer for a code repository
-after applying a patch.
+If that option is non-nil and Magit is loaded, piem uses Magit for some
+operations, particularly those that are user-facing.  This includes
+jumping to the Magit status buffer for a code repository after applying
+a patch.
 @findex piem-am-ready-mbox
 Note that the @code{piem-am} command works only for buffers from which
diff --git a/piem.el b/piem.el
index 780df00..c273138 100644
--- a/piem.el
+++ b/piem.el
@@ -139,7 +139,7 @@ (defcustom piem-git-executable
   "Which git executable to use."
   :type 'string)
-(defcustom piem-use-magit (featurep 'magit)
+(defcustom piem-use-magit t
   "Whether to use Magit for some user-facing operations."
   :type 'boolean)

      parent reply	other threads:[~2021-05-22 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22 20:39 [PATCH 0/2] piem-use-magit tweaks Kyle Meyer
2021-05-22 20:39 ` [PATCH 1/2] piem-use-magit: Reword docstring to clarify scope Kyle Meyer
2021-05-22 20:39 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210522203905.16504-3-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [PATCH 2/2] piem-use-magit: Unconditionally set to t' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).