From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:267::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms12 with LMTPS id kAKEDPlrqWALbwAAsNZ9tg (envelope-from ); Sat, 22 May 2021 20:39:21 +0000 Received: from out0.migadu.com ([2001:41d0:2:267::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wF0/NPRrqWDXTQAAB5/wlQ (envelope-from ); Sat, 22 May 2021 20:39:16 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1621715956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/MMunjkz4Ts0nPY1k8pSQbObaizSjs0PcnqvAbpW7pc=; b=ij11hjCOpTOnxmiEU6+DTR6ZjarX8xbpUn9BsiRuXEbeJG6aR9Op4W5qdSvLSWMu6aRlt0 5+0EXEOp4ZqoRWCuUODgaDU1iYqOGPoYsM2ddUyG4FnjPFUk49pjWuOAL018j2V6klCdV2 LMTGC+sbIkPeo8ZEf0K0tLL8cGOEzsKYohdeaDmIctpPqJk12/iVjq0Xn3ghlDbYihrlCl h+XD+3PtTQA2BqRJDQXik+eb3h41YWzcQ3dpgIXbB7LNz+BKZjSSiYnwxUOSeAKDzrEGWs vuNUJoh+w7pL/xAEnvUk1Zj2MuJWHc+GJeN/Cv0hZI0xIUtrzRvCd2s7NROPZA== From: Kyle Meyer To: piem@inbox.kyleam.com Subject: [PATCH 2/2] piem-use-magit: Unconditionally set to t Date: Sat, 22 May 2021 16:39:05 -0400 Message-Id: <20210522203905.16504-3-kyle@kyleam.com> In-Reply-To: <20210522203905.16504-1-kyle@kyleam.com> References: <20210522203905.16504-1-kyle@kyleam.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyle@kyleam.com X-TUID: b1OzNoMqgPg+ When piem is loaded, piem-use-magit is enabled if Magit has already been loaded. This approach is potentially confusing: a user may want to use Magit, be happy that it seems to just work, and then confused when it doesn't work in some later session where loading Magit happens to not be triggered before loading piem. All the relevant sites have fboundp guards (and those are cheap), so there's no advantage to disabling this if Magit isn't enabled at load time. Set piem-use-magit to t by default. --- Documentation/piem.texi | 9 ++++----- piem.el | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Documentation/piem.texi b/Documentation/piem.texi index 0f5235c..ca6a97b 100644 --- a/Documentation/piem.texi +++ b/Documentation/piem.texi @@ -265,11 +265,10 @@ Applying patches contained in a message @cindex magit @vindex piem-use-magit -When piem loads, it detects whether Magit is loaded and sets -@code{piem-use-magit} accordingly. If that option is non-nil, piem uses -Magit for some operations, particularly those that are user-facing. -This includes jumping to the Magit status buffer for a code repository -after applying a patch. +If that option is non-nil and Magit is loaded, piem uses Magit for some +operations, particularly those that are user-facing. This includes +jumping to the Magit status buffer for a code repository after applying +a patch. @findex piem-am-ready-mbox Note that the @code{piem-am} command works only for buffers from which diff --git a/piem.el b/piem.el index 780df00..c273138 100644 --- a/piem.el +++ b/piem.el @@ -139,7 +139,7 @@ (defcustom piem-git-executable "Which git executable to use." :type 'string) -(defcustom piem-use-magit (featurep 'magit) +(defcustom piem-use-magit t "Whether to use Magit for some user-facing operations." :type 'boolean) -- 2.31.1