discussion and development of piem
 help / color / mirror / code / Atom feed
* [PATCH] Decode more message headers
@ 2021-01-03  6:34 Kyle Meyer
  0 siblings, 0 replies; only message in thread
From: Kyle Meyer @ 2021-01-03  6:34 UTC (permalink / raw)
  To: piem

piem-extract-mbox-info feeds the "from" header value through
rfc2047-decode-string, but the same treatment should be applied to
other header values.
---
 piem-gnus.el |  7 +++++--
 piem.el      | 25 +++++++++++++------------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/piem-gnus.el b/piem-gnus.el
index 9dc4ae8..2674d05 100644
--- a/piem-gnus.el
+++ b/piem-gnus.el
@@ -31,6 +31,7 @@ (require 'gnus)
 (require 'gnus-sum)
 (require 'message)
 (require 'piem)
+(require 'rfc2047)
 
 (defgroup piem-gnus nil
   "Gnus integration for piem."
@@ -85,8 +86,10 @@ (defun piem-gnus-am-ready-mbox ()
       (when-let ((patch (with-current-buffer gnus-article-buffer
                           (save-restriction
                             (widen)
-                            (and (string-match-p piem-patch-subject-re
-                                                 (message-field-value "subject"))
+                            (and (string-match-p
+                                  piem-patch-subject-re
+                                  (rfc2047-decode-string
+                                   (message-field-value "subject")))
                                  (buffer-substring-no-properties
                                   (point-min) (point-max)))))))
         (cons (lambda () (insert patch))
diff --git a/piem.el b/piem.el
index acbbc4c..b716fea 100644
--- a/piem.el
+++ b/piem.el
@@ -302,17 +302,22 @@ (defun piem-message-link-re (url &optional mid)
                               (one-or-more (not (any "/" "\n")))))))
          string-end)))
 
+(defun piem--message-fetch-decoded-fields (headers)
+  (save-excursion
+    (save-restriction
+      (message-narrow-to-head)
+      (mapcar (lambda (header)
+                (when-let ((val (message-fetch-field header)))
+                  (rfc2047-decode-string val)))
+              headers))))
+
 (defun piem-inbox-by-header-match ()
   "Return inbox based on matching message headers.
 This should be called from a buffer containing a message and is
 intended to be used by libraries implementing a function for
 `piem-get-mid-functions'."
   (pcase-let ((`(,listid ,to ,cc)
-               (save-restriction
-                 (message-narrow-to-head)
-                 (list (message-fetch-field "list-id")
-                       (message-fetch-field "to")
-                       (message-fetch-field "cc")))))
+               (piem--message-fetch-decoded-fields '("list-id" "to" "cc"))))
     (catch 'hit
       (dolist (inbox piem-inboxes)
         (let* ((info (cdr inbox))
@@ -582,13 +587,9 @@ (defun piem-extract-mbox-info (&optional buffer)
 If BUFFER is nil, the current buffer is used.  Any message after
 the first will be ignored."
   (with-current-buffer (or buffer (current-buffer))
-    (let ((info (save-excursion
-                  (save-restriction
-                    (message-narrow-to-head)
-                    (list :date (message-fetch-field "date")
-                          :from (when-let ((from (message-fetch-field "from")))
-                                  (rfc2047-decode-string from))
-                          :subject (message-fetch-field "subject"))))))
+    (let ((info (cl-mapcan #'list '(:date :from :subject)
+                           (piem--message-fetch-decoded-fields
+                            '("date" "from" "subject")))))
       (when (re-search-forward (rx line-start "base-commit: "
                                    (group (>= 40 hex-digit))
                                    line-end)

base-commit: 10ac8491c370b683b0e3fad8150462407719957a
-- 
2.29.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-03  6:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03  6:34 [PATCH] Decode more message headers Kyle Meyer

discussion and development of piem

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.kyleam.com/piem/0 piem/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 piem piem/ https://inbox.kyleam.com/piem \
		piem@inbox.kyleam.com
	public-inbox-index piem

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.piem


code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git