Re: [PATCH 1/1] piem-notmuch-am-ready-mbox: Add option to edit patches before applying them

[Leo <sourcehut@relevant-information.com>]

Leo <sourcehut@relevant-information.com> writes:

> I actually thought something similar a while after I sent the patch.
> Instead of editing the buffer generated by notmuch we could use the
> buffer returned by `piem-am-ready-mbox'. That way we get all the
> libraries for free. Perhaps a new command `piem-am-edit' could be added
> that calls `piem-am-ready-mbox' with your suggested dedicated piem mode
> for editing. Would it be a good idea to filter out email headers that
> `git am' doesn't care about here? Otherwise it can be a bit overwhelming.
>
>
>
Here is a sketch based on the sketch you sent. The workflow being: 1)
call `piem-edit' 2) edit the mbox buffer 3) call `piem-edit-patch-am'.


---
 piem.el | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/piem.el b/piem.el
index afe6b7a..807de65 100644
--- a/piem.el
+++ b/piem.el
@@ -900,6 +900,35 @@ (defun piem-am-read-worktree (coderepo branch)
           (concat (file-name-nondirectory fname) "-"
                   (replace-regexp-in-string "/" "-" branch))))))
 
+(defvar-local piem-edit-patch--coderepo nil)
+(defvar-local piem-edit-patch--format nil)
+(defvar-local piem-edit-patch--mid nil)
+
+(defun piem-edit-patch-am ()
+  (interactive)
+  (piem-am (current-buffer)
+       "mbox"
+       (piem-extract-mbox-info (current-buffer))
+       piem-edit-patch--coderepo))
+
+(define-derived-mode piem-edit-patch-mode nil "piem-edit-patch"
+  "TODO"
+  :group 'piem)
+
+(defvar piem-edit-patch-mode-map
+  (let ((map (make-sparse-keymap)))
+    (define-key map (kbd "C-c C-c") #'piem-edit-patch-am)
+    map)
+  "TODO")
+
+(defun piem-edit ()
+  (interactive)
+  (piem-am-ready-mbox)
+  (let ((coderepo (piem-inbox-coderepo)))
+    (switch-to-buffer " *piem am-ready mbox*")
+    (piem-edit-patch-mode)
+    (setq piem-edit-patch--coderepo coderepo)))
+
 ;;;###autoload
 (defun piem-am (mbox &optional format info coderepo toggle-worktree)
   "Feed an am-ready mbox to `git am'.
-- 
2.31.0