From: Kyle Meyer <email@example.com>
Subject: Re: [PATCH] Support adding Message-Id to attached patches
Date: Sat, 13 Jun 2020 03:21:39 +0000 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Kyle Meyer writes:
> +(defcustom piem-add-message-id-header nil
> + "Whether to add Message-Id header to non-mail patches.
> +If this value is non-nil and a patch returned by a function in
> +`piem-am-ready-mbox-functions' looks like a patch that was
> +attached rather than sent inline, add a Message-Id header with
> +the value of `piem-mid'."
s/value of/value returned by/
> + (while (re-search-forward
> + (rx "From " (>= 40 hex-digit) " Mon Sep 17 00:00:00 2001")
This regexp should be anchored at the start of the line.
> + nil t)
> + (search-forward "\n\n")
> + (forward-line -1)
> + (insert (format "Message-Id: <%s>\n" mid)))))
The From line above is very unlikely to be in the commit message and
can't be in a diff line if the regexp is anchored. Still it's probably
worth trying a little harder to check the surroundings.
next prev parent reply other threads:[~2020-06-13 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 4:55 [PATCH] Support adding Message-Id to attached patches Kyle Meyer
2020-06-13 3:21 ` Kyle Meyer [this message]
2020-06-13 4:49 ` [PATCH v2] " Kyle Meyer
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).