From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyle@kyleam.com>
Received: from mp10.migadu.com ([2001:41d0:1004:224b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms12.migadu.com with LMTPS
	id kNZlLn4BhGSF/gAATFOONw
	(envelope-from <kyle@kyleam.com>)
	for <larch@inbox.kyleam.com>; Sat, 10 Jun 2023 06:52:14 +0200
Received: from mta0.migadu.com ([2001:41d0:1004:224b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp10.migadu.com with LMTPS
	id UGVPLX4BhGRlWAEAG6o9tA
	(envelope-from <kyle@kyleam.com>)
	for <larch@inbox.kyleam.com>; Sat, 10 Jun 2023 06:52:14 +0200
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1;
	t=1686372734;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to; bh=d4DHl++KFo/fO7pgm8QYbgi8+YRApNiskIAH3QjUyuU=;
	b=bF51KYGwWNS3WXtwNrarSJcOp4opkKWi7qenbSsezsFa6r2BA60jJm8L+6JLK+lFHQZ93R
	f0VmLR5Ew4QhwCeYHHbHC73c6U8iuhJEeqavlKE6qsx4781p6mNhVUXujIv+adyLZfyKGs
	ReJgyaoXJyZU2pce4Yak60EPhrrxfXm8Lj17YhlnDV3tep152/Qn97+GVYooKsFS74svPb
	K7m4S2hVx9H8DXn95EXAOjrn+DByLKY/yUyXTO/f77PNUtpvxaHzL9Mo1u6YyvIXRLzlwV
	Un9dy1b7mvmPDLArFuadY9O9z2BxAXpLe1FInIWcHmgasDDrJmoq4dPVOtczaQ==
From: Kyle Meyer <kyle@kyleam.com>
To: jlicht@fsfe.org
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH v2 1/5] piem: Add :gnu-package keyword to piem-inboxes
In-Reply-To: <20230609124829.29629-2-jlicht@fsfe.org>
Date: Sat, 10 Jun 2023 00:52:11 -0400
Message-ID: <87v8fvnclg.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-TUID: IxH4XovgOzPY

jlicht@fsfe.org writes:

> With the `:gnu-package` keyword, users can configure a regex to match
> against the X-GNU-PR-PACKAGE email header for the GNU Bug Tracker.

Is a regex needed, or would plain string comparison (on downcased
string) be sufficient?

If it is needed, I think the documentation should be adjusted to mention
it's a regex.  That's a bit different than the other headers, where the
user input value itself isn't treated as a regex, even if internally the
match is done with a regex, mostly to handle surrounding text that comes
along with the header.  (As a complete side remark: looking at the
:address handling, it should probably be more careful to not match just
a substring of an address.)

> ---
> diff --git a/Documentation/piem.texi b/Documentation/piem.texi
> index 26962a4..99185d3 100644
> --- a/Documentation/piem.texi
> +++ b/Documentation/piem.texi
> @@ -168,6 +168,12 @@ repository (e.g., if the inbox receives patches for multiple projects,
>  or if you use a few dedicated Git worktrees for different types of
>  patches), set @code{:coderepo} to a list of locations.
>  
> +@cindex issue tracking
> +@cindex Debbugs, issue tracking system
> +When using the Debbugs instance at @uref{https://bugs.gnu.org} to
> +retrieve messages, an inbox can mapped to each message by setting
> +@code{:gnu-package} for an inbox.

Nice, thanks for updating the texi docs.

Reading this made me think about other instances (Debian, perhaps
others), but I'll leave worrying about that until someone interested
comes along.

> @@ -393,7 +395,7 @@ files."
>                    (rx string-start "publicinbox."
>                        (group (one-or-more not-newline)) "."
>                        (group
> -                       (or "address" "coderepo" "listid" "maildir" "url"))
> +                       (or "address" "coderepo" "listid" "maildir" "url" "gnu-package"))

Please move "gnu-package" onto the next line to avoid going too far over
~80 characters.