discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH] process buffer: Restore header's leading newline
Date: Wed, 09 Dec 2020 00:32:35 GMT
Message-ID: <87h7ovstub.fsf@kyleam.com> (raw)
In-Reply-To: <20201127205815.17313-1-kyle@kyleam.com>


Kyle Meyer writes:

> @@ -231,10 +232,14 @@ (defun piem--process-go (dir program program-args fn)
>        (goto-char (point-max))
>        (display-buffer buffer)
>        (let ((inhibit-read-only t))
> -        (insert (format "\n%s\n;;; process: %S\n;;; directory:  %s\n"
> +        (insert (format (concat "%s\n"
> +                                ";;; process: %S\n"

I should've taken a closer look before applying.  This lost a newline.

-- >8 --
Subject: [PATCH] process buffer: Restore header's leading newline

94d0281 (process buffer: Add time to header, 2020-11-27) was just
supposed to add a "time:" field, but it also dropped the leading "\n".
Add it back, and also avoid the unnecessary concat call.
---
 piem.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/piem.el b/piem.el
index addc27e..0ee4ca6 100644
--- a/piem.el
+++ b/piem.el
@@ -232,10 +232,12 @@ (defun piem--process-go (dir program program-args fn)
       (goto-char (point-max))
       (display-buffer buffer)
       (let ((inhibit-read-only t))
-        (insert (format (concat "%s\n"
-                                ";;; process: %S\n"
-                                ";;; directory:  %s\n"
-                                ";;; time: %s\n")
+        (insert (format "
+%s
+;;; process: %S
+;;; directory:  %s
+;;; time: %s
+"
                         (char-to-string 12) ; form feed
                         (cons program program-args)
                         default-directory

base-commit: 94d028164dc6e9e94a2761af86d6a38e2873296d
-- 
2.29.2


      reply	other threads:[~2020-12-09  0:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 20:58 [PATCH] process buffer: Add time to header Kyle Meyer
2020-12-09  0:32 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7ovstub.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [PATCH] process buffer: Restore header'\''s leading newline' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

discussion and development of piem

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.kyleam.com/piem/0 piem/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 piem piem/ https://inbox.kyleam.com/piem \
		piem@inbox.kyleam.com
	public-inbox-index piem

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.piem


code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git