From: Kyle Meyer <kyle@kyleam.com>
To: Leo <git@relevant-information.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH] *-am-ready-mbox: Don't require PATCH prefix
Date: Mon, 05 Feb 2024 23:08:41 -0500 [thread overview]
Message-ID: <87eddqnsja.fsf@kyleam.com> (raw)
In-Reply-To: <87sf272ojs.fsf@>
[ adding piem inbox back to cc ]
Leo writes:
> Kyle Meyer <kyle@kyleam.com> writes:
>>
>> This change makes it more likely that a piem-am caller invokes 'git
>> am' on something that's not a valid patch, but in that case 1) the
>> output buffer gives a reasonable error
>>
> The only comment I have is that running piem-am with this patch on a
> non-patch buffer (and selecting a repo to apply it on) will create a new
> branch and put git in a state of failing to apply a patch. You need to
> clean it up by deleting the branch and running `git am --abort` in the
> repository. This seems reasonable to me. Both are easy to do, and is
> what you would expect to happen if you run `git-am` with a broken patch
> (well not really the branch, but I think that's fine).
Right, that is worth spelling out. Thanks.
next prev parent reply other threads:[~2024-02-06 4:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 10:09 Could not find am-ready mbox for current buffer Leo
2024-02-04 19:54 ` [PATCH] *-am-ready-mbox: Don't require PATCH prefix Kyle Meyer
2024-02-04 20:12 ` Kyle Meyer
[not found] ` <87sf272ojs.fsf@>
2024-02-06 4:08 ` Kyle Meyer [this message]
2024-02-12 3:44 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eddqnsja.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=git@relevant-information.com \
--cc=piem@inbox.kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).