From: Kyle Meyer <kyle@kyleam.com>
To: sourcehut@relevant-information.com
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH v3 2/2] Add user option for specifying path to notmuch-extract-patch
Date: Fri, 17 Dec 2021 00:22:54 -0500 [thread overview]
Message-ID: <87bl1fx0sx.fsf@kyleam.com> (raw)
In-Reply-To: <20211216193234.25745-2-sourcehut@relevant-information.com>
sourcehut@relevant-information.com writes:
> From: Leo <sourcehut@relevant-information.com>
>
> `notmuch-extract-patch` might not be available on PATH. This can be the
> case if the package wasn't installed through the distro package manager.
> ---
> My laptop didn't have mailscripts in the package repos so I had to
> install it from emacsmirror which didn't put the scripts in PATH. I
> thought this change might be useful for others as well so I decided to
> include it.
I okay with the general idea, but I held off on pushing this to propose
that instead you add a notmuch-extract-patch-executable defcustom
consistent with other spots in piem (piem-git-executable,
piem-b4-b4-executable, piem-lei-lei-executable).
That can be set to "notmuch-extract-patch" by default then ...
> (defun piem-notmuch-extract-patch-am-ready-mbox ()
> "Return a function that inserts an am-ready mbox.
> Use the message itself if it looks like a patch using
> @@ -120,7 +124,7 @@ (defun piem-notmuch-extract-patch-am-ready-mbox ()
> (mm-dissect-buffer))) 0))
> (let ((thread-id notmuch-show-thread-id))
> (lambda ()
> - (if-let ((cmd (executable-find "notmuch-extract-patch"))
> + (if-let ((cmd (or piem-notmuch-extract-patch-path (executable-find "notmuch-extract-patch")))
... instead of worrying about the executable-find call here, just pass
notmuch-extract-patch-executable to call-process as is. If call-process
can't find it, it will signal a clear enough error:
Searching for program: No such file or directory, notmuch-extract-patch
next prev parent reply other threads:[~2021-12-17 5:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 15:09 [PATCH v2] Use notmuch-extract-patch if available leo
2021-12-15 5:16 ` Kyle Meyer
2021-12-15 5:22 ` Kyle Meyer
2021-12-16 19:32 ` [PATCH v3 1/2] Support preparing am-ready mbox via notmuch-extract-patch sourcehut
2021-12-16 19:32 ` [PATCH v3 2/2] Add user option for specifying path to notmuch-extract-patch sourcehut
2021-12-17 5:22 ` Kyle Meyer [this message]
2021-12-21 19:15 ` [PATCH v4] " Leo
2021-12-24 18:31 ` Kyle Meyer
2021-12-17 5:15 ` [PATCH v3 1/2] Support preparing am-ready mbox via notmuch-extract-patch Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl1fx0sx.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=piem@inbox.kyleam.com \
--cc=sourcehut@relevant-information.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).