From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <public@yoctocell.xyz>
Received: from mp0 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms12 with LMTPS
	id KBB9BDOaS2COOQAAsNZ9tg
	(envelope-from <public@yoctocell.xyz>)
	for <larch@inbox.kyleam.com>; Fri, 12 Mar 2021 16:43:31 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0 with LMTPS
	id mEKRNC6aS2D1PgAA1q6Kng
	(envelope-from <public@yoctocell.xyz>)
	for <larch@inbox.kyleam.com>; Fri, 12 Mar 2021 16:43:26 +0000
Received: from mail.yoctocell.xyz (h87-96-130-155.cust.a3fiber.se [87.96.130.155])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id B02A913211
	for <piem@inbox.kyleam.com>; Fri, 12 Mar 2021 17:43:26 +0100 (CET)
From: Xinglu Chen <public@yoctocell.xyz>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz;
	s=mail; t=1615567405;
	bh=WkM3iFn4GBJyX0UEDkpd7EBQycgW61nwNkB7HMwQXeQ=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=lQ+i2owOLQqFv4saa0KBBgfRNO1hnqZoAnMPk4RQX8SgW9cBN2SQWycUTHFnCRT2K
	 5GGDlvSwlpunFkjC+l0Pt11fs4kN07lxdJH9YNucsczIBSQ2+lBV8BBdjJWzR8zbT0
	 p0M2n4Grb4nKIkYzGpac5tbj3hPX1ZFX2RVcQxd4=
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [RFC PATCH] Add :maildir keyword to piem-inboxes
In-Reply-To: <87im5x9rzh.fsf@kyleam.com>
References: <9ff4c94928b0cd0d223799fa8a978d94e545522e.1615460587.git.public@yoctocell.xyz>
 <87im5x9rzh.fsf@kyleam.com>
Date: Fri, 12 Mar 2021 17:43:24 +0100
Message-ID: <87a6r8gw5v.fsf@yoctocell.xyz>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_IN
X-Migadu-Spam-Score: -4.00
Authentication-Results: aspmx1.migadu.com;
	none
X-Migadu-Queue-Id: B02A913211
X-Spam-Score: -4.00
X-Migadu-Scanner: scn0.migadu.com
X-TUID: soEnHNaMxqLl

On Thu, Mar 11 2021, Kyle Meyer wrote:

>> diff --git a/Documentation/piem.texi b/Documentation/piem.texi
>> index ebd756d..9f8779f 100644
>> --- a/Documentation/piem.texi
>> +++ b/Documentation/piem.texi
>> @@ -410,7 +410,8 @@
>>  regular mail but are following a project via NNTP in Gnus).  In this
>>  case, you can use the command @code{piem-inject-thread-into-maildir} to
>>  move the thread's messages into a local Maildir directory
>> -(@code{piem-maildir-directory}).  By default the command downloads the
>> +(@code{piem-maildir-directory}, or the @code{:maildir} for the
>> +current inbox).  By default the command downloads the
>
> Hmm, with :maildir coming second, I think I'd interpret the priority to
> be opposite of what it is.  Perhaps something closer to the phrasing you
> used in the commit message:
>
>   ... into a local Maildir directory specified by the current inbox's
>   @code{:maildir} value in @code{piem-inboxes}, falling back to
>   @code{piem-maildir-directory}.

Good point.

>> +  (let ((maildir-directory (piem-inbox-maildir-directory)))
>> +    (cond
>> +     ((not maildir-directory)
>> +      (user-error "`maildir-directory' is not configured"))
>
> Unlike the previous piem-maildir-directory, maildir-directory is local
> to this function, so a user that sees this message can't learn more with
> `C-h v' and friends.  How about
>
>   "No directory returned by `piem-inbox-maildir-directory'"
>
> instead?

Sounds good to me.