Re: [RFC PATCH] Add :maildir keyword to piem-inboxes

[Xinglu Chen <public@yoctocell.xyz>]

On Thu, Mar 11 2021, Kyle Meyer wrote:

>> diff --git a/Documentation/piem.texi b/Documentation/piem.texi
>> index ebd756d..9f8779f 100644
>> --- a/Documentation/piem.texi
>> +++ b/Documentation/piem.texi
>> @@ -410,7 +410,8 @@
>>  regular mail but are following a project via NNTP in Gnus).  In this
>>  case, you can use the command @code{piem-inject-thread-into-maildir} to
>>  move the thread's messages into a local Maildir directory
>> -(@code{piem-maildir-directory}).  By default the command downloads the
>> +(@code{piem-maildir-directory}, or the @code{:maildir} for the
>> +current inbox).  By default the command downloads the
>
> Hmm, with :maildir coming second, I think I'd interpret the priority to
> be opposite of what it is.  Perhaps something closer to the phrasing you
> used in the commit message:
>
>   ... into a local Maildir directory specified by the current inbox's
>   @code{:maildir} value in @code{piem-inboxes}, falling back to
>   @code{piem-maildir-directory}.

Good point.

>> +  (let ((maildir-directory (piem-inbox-maildir-directory)))
>> +    (cond
>> +     ((not maildir-directory)
>> +      (user-error "`maildir-directory' is not configured"))
>
> Unlike the previous piem-maildir-directory, maildir-directory is local
> to this function, so a user that sees this message can't learn more with
> `C-h v' and friends.  How about
>
>   "No directory returned by `piem-inbox-maildir-directory'"
>
> instead?

Sounds good to me.