discussion and development of piem
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [RFC PATCH] Add :maildir keyword to piem-inboxes
Date: Fri, 12 Mar 2021 17:43:24 +0100	[thread overview]
Message-ID: <87a6r8gw5v.fsf@yoctocell.xyz> (raw)
In-Reply-To: <87im5x9rzh.fsf@kyleam.com>

On Thu, Mar 11 2021, Kyle Meyer wrote:

>> diff --git a/Documentation/piem.texi b/Documentation/piem.texi
>> index ebd756d..9f8779f 100644
>> --- a/Documentation/piem.texi
>> +++ b/Documentation/piem.texi
>> @@ -410,7 +410,8 @@
>>  regular mail but are following a project via NNTP in Gnus).  In this
>>  case, you can use the command @code{piem-inject-thread-into-maildir} to
>>  move the thread's messages into a local Maildir directory
>> -(@code{piem-maildir-directory}).  By default the command downloads the
>> +(@code{piem-maildir-directory}, or the @code{:maildir} for the
>> +current inbox).  By default the command downloads the
>
> Hmm, with :maildir coming second, I think I'd interpret the priority to
> be opposite of what it is.  Perhaps something closer to the phrasing you
> used in the commit message:
>
>   ... into a local Maildir directory specified by the current inbox's
>   @code{:maildir} value in @code{piem-inboxes}, falling back to
>   @code{piem-maildir-directory}.

Good point.

>> +  (let ((maildir-directory (piem-inbox-maildir-directory)))
>> +    (cond
>> +     ((not maildir-directory)
>> +      (user-error "`maildir-directory' is not configured"))
>
> Unlike the previous piem-maildir-directory, maildir-directory is local
> to this function, so a user that sees this message can't learn more with
> `C-h v' and friends.  How about
>
>   "No directory returned by `piem-inbox-maildir-directory'"
>
> instead?

Sounds good to me.

  reply	other threads:[~2021-03-12 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 11:06 Xinglu Chen
2021-03-11 23:43 ` Kyle Meyer
2021-03-12 16:43   ` Xinglu Chen [this message]
2021-03-12 16:55 ` [PATCH v2] piem: " Xinglu Chen
2021-03-13  1:18   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6r8gw5v.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --subject='Re: [RFC PATCH] Add :maildir keyword to piem-inboxes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).