From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yantar92@gmail.com>
Received: from mp10.migadu.com ([2001:41d0:403:4ea1::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms12 with LMTPS
	id mXF3E2uDdGK5WwAAsNZ9tg
	(envelope-from <yantar92@gmail.com>)
	for <larch@inbox.kyleam.com>; Fri, 06 May 2022 02:09:47 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp10.migadu.com with LMTPS
	id 6HuSDmuDdGJfHAAAG6o9tA
	(envelope-from <yantar92@gmail.com>)
	for <larch@inbox.kyleam.com>; Fri, 06 May 2022 04:09:47 +0200
Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 16C571B70
	for <piem@inbox.kyleam.com>; Fri,  6 May 2022 04:09:44 +0200 (CEST)
Received: by mail-pj1-x102b.google.com with SMTP id l11-20020a17090a49cb00b001d923a9ca99so5680032pjm.1
        for <piem@inbox.kyleam.com>; Thu, 05 May 2022 19:09:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:in-reply-to:references:date:message-id
         :mime-version;
        bh=vt+giNRGEL1KXkxuUtjXDC6kUFrUY6Wdt/cOxKVmbpk=;
        b=hWrXB12TYMvLLu/XoZDUWlOBwmM3hw9xHzo/uQ5YCX2Ux2bEggJ4QT71AJIRwPh08g
         eNcUmGbjAW8UqstVYI8y8Yrq6wynsGHwo8mlx866PnJIednoHjVzt1Rs4Ps+dbA1UGwZ
         mhiysPf9NjtjfD1Gl/UT/E6d+ueBLoiYnmTpTZrIWIJFbwTN1EMid2X0G176Tr09geU4
         0l/KjPKWgZ8HfXEcivH3Hz4JQGB+SmuFu50sv28XTnLIlmiKzba5b5L+I7khMGEwvjsc
         LQmNCubPokrHlwK6kqIcqX+FN+NfltEEhH9WrggIZt3/VGO3s+BNalFVvgfMnqS+92Sx
         Ulnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
         :message-id:mime-version;
        bh=vt+giNRGEL1KXkxuUtjXDC6kUFrUY6Wdt/cOxKVmbpk=;
        b=z5TSHKWGk2XHZ1KOJNmSglFyWMVcOUOmjA5GcAdNoW65Sh8RIzjbv1M4r/QrJVHVK6
         9BqBbfjccBzHAPYzxF3yy5hyMSUkdipdj6Hmbb1kaTkVN5fbO4mqAic/mWcdY9cuOa4G
         z+mu3qCdp9isjwgvKatID8RBFvIMqUNECNZVH+6tSqpKgU0AGPGHYYkFCDgJWIOWTtob
         HYzvsQdv/ZoVN6rODHTMQSr6Rurn5VJ0gBa99Qlj3qMQHpJQHcWO0RbqViDrB1qO0tHH
         2843qImz/kKHsNViYXjasYVlBgEEMlrMIhxuoUTCnElGXvRkfVaQeOyITcH54scWjg4E
         My1w==
X-Gm-Message-State: AOAM5308oD4WTpYbgK1X7TQ4mqkiLSuxcrmxS0BFa6WZ1XlIYGYh4npF
	W7FwIlxg590f5Vf7ubm7NPY=
X-Google-Smtp-Source: ABdhPJxpY/iqWOO/rZvIjaKBjAkY+42NriBMj1e/MRwhSSC33AuAYy4LbTVeQzgxW+ti3Az2enxR3g==
X-Received: by 2002:a17:90a:e2cb:b0:1da:35d6:3a08 with SMTP id fr11-20020a17090ae2cb00b001da35d63a08mr9684499pjb.223.1651802982698;
        Thu, 05 May 2022 19:09:42 -0700 (PDT)
Received: from localhost ([66.115.157.242])
        by smtp.gmail.com with ESMTPSA id b12-20020a170902b60c00b0015e8d4eb2d4sm284298pls.286.2022.05.05.19.09.41
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 05 May 2022 19:09:42 -0700 (PDT)
From: Ihor Radchenko <yantar92@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH] piem-inboxes: Support mapping inbox to multiple coderepos
In-Reply-To: <20220506014017.14259-1-kyle@kyleam.com>
References: <87pml6871p.fsf@kyleam.com>
 <20220506014017.14259-1-kyle@kyleam.com>
Date: Fri, 06 May 2022 10:10:25 +0800
Message-ID: <874k238l7y.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Authentication-Results: aspmx1.migadu.com;
	none
X-Migadu-Scanner: scn1.migadu.com
X-TUID: bwF07AuSbE1A

Kyle Meyer <kyle@kyleam.com> writes:

> An inbox may regularly receive patches for multiple repos.  Allow an
> inbox's :coderepo to be a list, and teach piem-inbox-coderepo to
> select a target repo by prompting the caller with the configured list.

Thanks!

> @@ -100,8 +102,7 @@ (defcustom piem-inboxes nil
>    ;; `piem--merge-config-inboxes' so that the value can also be set in
>    ;; ~/.public-inbox/config.
>    :type '(alist :key-type string
> -                :value-type
> -                (plist :value-type string))
> +                :value-type plist)

:value-type plist seems wrong, unless I miss something. Even a list of
strings will not necessarily match this value type when there are e.g. 3
repos associated with an inbox.

> -               (when-let ((coderepo
> +               (when-let ((coderepos
>                             (and (eq prop-name :coderepo)
> -                                (car (gethash
> -                                      (format "coderepo.%s.dir" (car val))
> -                                      pi-cfg)))))
> +                                (mapcar
> +                                 (lambda (v)
> +                                   (car (gethash (format "coderepo.%s.dir" v)
> +                                                 pi-cfg)))
> +                                 val))))

Does it mean that :coderepo "a single string" format is no longer supported?

Best,
Ihor