From: Ihor Radchenko <yantar92@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: piem@inbox.kyleam.com
Subject: Re: [PATCH] piem-inboxes: Support mapping inbox to multiple coderepos
Date: Fri, 06 May 2022 10:10:25 +0800 [thread overview]
Message-ID: <874k238l7y.fsf@localhost> (raw)
In-Reply-To: <20220506014017.14259-1-kyle@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
> An inbox may regularly receive patches for multiple repos. Allow an
> inbox's :coderepo to be a list, and teach piem-inbox-coderepo to
> select a target repo by prompting the caller with the configured list.
Thanks!
> @@ -100,8 +102,7 @@ (defcustom piem-inboxes nil
> ;; `piem--merge-config-inboxes' so that the value can also be set in
> ;; ~/.public-inbox/config.
> :type '(alist :key-type string
> - :value-type
> - (plist :value-type string))
> + :value-type plist)
:value-type plist seems wrong, unless I miss something. Even a list of
strings will not necessarily match this value type when there are e.g. 3
repos associated with an inbox.
> - (when-let ((coderepo
> + (when-let ((coderepos
> (and (eq prop-name :coderepo)
> - (car (gethash
> - (format "coderepo.%s.dir" (car val))
> - pi-cfg)))))
> + (mapcar
> + (lambda (v)
> + (car (gethash (format "coderepo.%s.dir" v)
> + pi-cfg)))
> + val))))
Does it mean that :coderepo "a single string" format is no longer supported?
Best,
Ihor
next prev parent reply other threads:[~2022-05-06 2:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 7:48 [FR] Support multiple repositories associated with the same ML Ihor Radchenko
2022-04-24 22:12 ` Kyle Meyer
2022-04-26 9:19 ` Applying the same patch multiple times (was: [FR] Support multiple repositories associated with the same ML) Ihor Radchenko
2022-04-27 3:49 ` Applying the same patch multiple times Kyle Meyer
2022-04-27 12:46 ` Ihor Radchenko
2022-05-07 14:19 ` Kyle Meyer
2022-05-06 1:40 ` [PATCH] piem-inboxes: Support mapping inbox to multiple coderepos Kyle Meyer
2022-05-06 2:10 ` Ihor Radchenko [this message]
2022-05-06 3:28 ` Kyle Meyer
2022-05-07 5:21 ` Ihor Radchenko
2022-05-07 14:18 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k238l7y.fsf@localhost \
--to=yantar92@gmail.com \
--cc=kyle@kyleam.com \
--cc=piem@inbox.kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).