From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:863f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms12 with LMTPS id wj49GODgsmGECAAAsNZ9tg (envelope-from ) for ; Fri, 10 Dec 2021 05:08:48 +0000 Received: from out1.migadu.com ([2001:41d0:2:863f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id e3IAE+DgsmGoSQAAB5/wlQ (envelope-from ) for ; Fri, 10 Dec 2021 05:08:48 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1639112928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dkmtNbaNELtj578Ng53O149jrSecSw3ByphTFl+AawA=; b=fp8JRtv8BWlZCCSznMoLi52USdCStVgMY9d0+Ea9xKRIBp7J6BEXsI7UHNKojaUElyzPzZ 37JfQ0g/Klxh5DhMNGwyFQObzZQM1SVAh7m1nsKKL7d2GHoojnb0WpHVOj2PVwbs9PDdou AD/4NwD5jJBNEw+bN0WyHOmkO1ZxcqvVujcF/D9zyZUnylRdIEuf8ZiFMmqBdJxH2eK6X6 zoDdhcP2WTKZFQcFc14LpFFUsYFoSz3q/yLp976iTSauIitzIFuCIsxZGnDJIickSclQpC ZqR1TqCb3ZkdFBx9k5jKj1mHwBVuIeut+UX2/ngQTOKV3qU9M8HY0i1wCY3yyA== From: Kyle Meyer To: Leo Cc: piem@inbox.kyleam.com Subject: Re: [PATCH 1/1] piem-notmuch-am-ready-mbox: Add option to edit patches before applying them In-Reply-To: <87zgpaylus.fsf@hako.i-did-not-set--mail-host-address--so-tickle-me> References: <20211208160142.84085-1-sourcehut@relevant-information.com> <20211208160142.84085-2-sourcehut@relevant-information.com> <87r1amfnoa.fsf@kyleam.com> <87v8zynkhy.fsf@relevant-information.com> <87zgpaylus.fsf@hako.i-did-not-set--mail-host-address--so-tickle-me> Date: Fri, 10 Dec 2021 00:08:40 -0500 Message-ID: <871r2lf3mv.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyle@kyleam.com X-TUID: 9QoCvw1Qhmtj Leo writes: > Leo writes: > >> I actually thought something similar a while after I sent the patch. >> Instead of editing the buffer generated by notmuch we could use the >> buffer returned by `piem-am-ready-mbox'. That way we get all the >> libraries for free. Perhaps a new command `piem-am-edit' could be added >> that calls `piem-am-ready-mbox' with your suggested dedicated piem mode >> for editing. Would it be a good idea to filter out email headers that >> `git am' doesn't care about here? Otherwise it can be a bit overwhelming. Yeah, filtering headers (and perhaps positioning point) sounds like a good idea. Note sure if any built-in Emacs libraries have something to use or at least follow here. > Here is a sketch based on the sketch you sent. The workflow being: 1) > call `piem-edit' 2) edit the mbox buffer 3) call `piem-edit-patch-am'. Nice, seems like we're looking in the same general direction. (I unfortunately don't have time tonight to give a more substantial reply to this or your other thread.) Is this topic something you'd like to flesh out and polish? (No worries if not.)