From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:1004:224b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4HmRBcHoTmRjnQAAkFu2QA (envelope-from ); Mon, 01 May 2023 00:16:33 +0200 Received: from mta0.migadu.com ([2001:41d0:1004:224b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ADZWBcHoTmRDRQAAauVa8A (envelope-from ); Mon, 01 May 2023 00:16:33 +0200 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1682892992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=siFyOxL8DCTQm3QD4BzPRQ8AY6GVPcanb8FclQEjY5Q=; b=b2JwZ76lUxFG71gCS0BX8Iwt31fER/GVhLY3Eoxdz1k2XsQnXSky0f7qu64Z0M2XaqA45v i2PPaD73NqBQFHRZ3l63+PNeoLf1QtMp4t3vOdF/ZZ2Yy7doULhvCS6ycY5AWOOzSgNtN2 qHcjo0J8bRZ+P4WMpkWT7mvZn1R1nXryE9d9zeFI1v9eWfCDnVOQjBdXzdcr1naSCPybkS vX8rKr1huthsppj0ZXmr+u7p11s2uI6V5V1SyD578SoqNznNhT0xR7uQcuZ9I9TGKs/0SG nPIaQ/CU6r0KnXS/FZuOm/xwgYz4URHjNwoR3/fybNPZoDrblBsOsfzOTb/+GQ== From: Kyle Meyer To: piem@inbox.kyleam.com Subject: [PATCH 3/4] piem-am-ready-mbox: Change spelling of inserted message ID header Date: Sun, 30 Apr 2023 18:15:51 -0400 Message-Id: <20230430221552.251335-4-kyle@kyleam.com> In-Reply-To: <20230430221552.251335-1-kyle@kyleam.com> References: <20230430221552.251335-1-kyle@kyleam.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-TUID: LYbnl4S6uAv8 format-patch changed from Message-Id to Message-ID in git.git's ba4324c4e1 (e-mail workflow: Message-ID is spelled with ID in both capital letters, 2023-04-03). Update piem--insert-message-id-header to follow Git's change. --- piem.el | 6 +++--- tests/piem-tests.el | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/piem.el b/piem.el index 9dc7f3e3..01985f0e 100644 --- a/piem.el +++ b/piem.el @@ -156,10 +156,10 @@ (defcustom piem-am-ready-mbox-functions nil :type 'hook) (defcustom piem-add-message-id-header nil - "Whether to add Message-Id header to non-mail patches. + "Whether to add Message-ID header to non-mail patches. If this value is non-nil and a patch returned by a function in `piem-am-ready-mbox-functions' looks like a patch that was -attached rather than sent inline, add a Message-Id header with +attached rather than sent inline, add a Message-ID header with the return value of `piem-mid'." :type 'boolean) @@ -615,7 +615,7 @@ (defun piem--insert-message-id-header (mid) (when (= header-count 3) ;; Found all the expected headers before hitting a ;; blank line. Assume we're in a header. - (insert (format "Message-Id: <%s>\n" mid)))))))) + (insert (format "Message-ID: <%s>\n" mid)))))))) (defun piem-am-ready-mbox (&optional buffer-name) "Generate a buffer containing an am-ready mbox. diff --git a/tests/piem-tests.el b/tests/piem-tests.el index 6f39a53e..7f9f30f3 100644 --- a/tests/piem-tests.el +++ b/tests/piem-tests.el @@ -181,7 +181,7 @@ (ert-deftest piem--insert-message-id-header () (piem--insert-message-id-header "msg@id"))) (should-not (string-match-p - "Message-Id: " + "Message-ID: " (with-temp-buffer (insert "\ From 0d732713af1f3fb48b37430e2cd0a3033cea14f3 Mon Sep 17 00:00:00 2001 @@ -200,9 +200,9 @@ (ert-deftest piem--insert-message-id-header () (should (string-match-p (concat - (rx "Subject: [PATCH 1/2] a\nMessage-Id: \n" + (rx "Subject: [PATCH 1/2] a\nMessage-ID: \n" (one-or-more anychar) - "Subject: [PATCH 2/2] b\nMessage-Id: \n")) + "Subject: [PATCH 2/2] b\nMessage-ID: \n")) (with-temp-buffer (insert "\ From 0d732713af1f3fb48b37430e2cd0a3033cea14f3 Mon Sep 17 00:00:00 2001 -- 2.39.2